Fix elasticsearch result ids returning as strings (#487)

sai-prasanna · web-flow · commit 8cf7dabe45ad · 2020-08-31T12:42:45.000+02:00
diff --git a/src/nlp/search.py b/src/nlp/search.py
@@ -179,7 +179,7 @@ def search(self, query: str, k=10) -> SearchResults:
             body={"query": {"multi_match": {"query": query, "fields": ["text"], "type": "cross_fields"}}, "size": k},
         )
         hits = response["hits"]["hits"]
-        return SearchResults([hit["_score"] for hit in hits], [hit["_id"] for hit in hits])
+        return SearchResults([hit["_score"] for hit in hits], [int(hit["_id"]) for hit in hits])
 
 
 class FaissIndex(BaseIndex):

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ def search(self, query: str, k=10) -> SearchResults:`
`179`	`179`	`body={"query": {"multi_match": {"query": query, "fields": ["text"], "type": "cross_fields"}}, "size": k},`
`180`	`180`	`)`
`181`	`181`	`hits = response["hits"]["hits"]`
`182`		`- return SearchResults([hit["_score"] for hit in hits], [hit["_id"] for hit in hits])`
	`182`	`+ return SearchResults([hit["_score"] for hit in hits], [int(hit["_id"]) for hit in hits])`
`183`	`183`
`184`	`184`
`185`	`185`	`class FaissIndex(BaseIndex):`