Merge pull request #24 from adam-lynch/patch-1

Don't check what's returned from passed function

Author: shinnn

index.js

@@ -28,8 +28,8 @@ function gulpRename(obj) {
 
 		} else if (type === "function") {
 
-			var result = obj(parsedPath) || parsedPath;
-			path = Path.join(result.dirname, result.basename + result.extname);
+			obj(parsedPath);
+			path = Path.join(parsedPath.dirname, parsedPath.basename + parsedPath.extname);
 
 		} else if (type === "object" && obj !== undefined && obj !== null) {
 

test/rename.spec.js

@@ -150,15 +150,24 @@ describe("gulp-rename", function () {
 			helper(srcPattern, obj, expectedPath, done);
 		});
 
-		it("can return a whole new object", function (done) {
+		it("ignores the return value", function (done) {
 			var obj = function (/*path*/) {
 				return {
 					dirname: "elsewhere",
 					basename: "aloha",
 					extname: ".md"
 				};
 			};
-			var expectedPath = "test/elsewhere/aloha.md";
+			var expectedPath = "test/fixtures/hello.txt";
+			helper(srcPattern, obj, expectedPath, done);
+		});
+
+		it("receives object with extname even if a different value is returned", function (done) {
+			var obj = function (path) {
+				path.extname.should.equal(".txt");
+				return path.extname = ".md";
+			};
+			var expectedPath = "test/fixtures/hello.md";
 			helper(srcPattern, obj, expectedPath, done);
 		});
 	});