Skip to content

Commit 8e2137b

Browse files
bwp91bwp91
committed
fix: add missing translation in compatibility modal
1 parent 12256a8 commit 8e2137b

29 files changed

+40
-11
lines changed

‎ui/src/app/core/manage-plugins/manage-plugins.service.ts‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -207,17 +207,13 @@ export class ManagePluginsService {
207207

208208
try {
209209
// Check Node.js version from the `package.engines` of the plugin being installed/updated
210-
if (plugin.updateEngines?.node) {
211-
if (lt(this.$settings.env.nodeVersion, minVersion(plugin.updateEngines.node))) {
212-
isValidNode = false;
213-
}
210+
if (plugin.updateEngines?.node && lt(this.$settings.env.nodeVersion, minVersion(plugin.updateEngines.node))) {
211+
isValidNode = false;
214212
}
215213

216214
// Check Homebridge version from the `package.engines` of the plugin being installed/updated
217-
if (plugin.updateEngines?.homebridge) {
218-
if (lt(this.$settings.env.homebridgeVersion, minVersion(plugin.updateEngines.homebridge))) {
219-
isValidHb = false;
220-
}
215+
if (plugin.updateEngines?.homebridge && lt(this.$settings.env.homebridgeVersion, minVersion(plugin.updateEngines.homebridge))) {
216+
isValidHb = false;
221217
}
222218
} catch (e) {
223219
this.$toastr.error(`Failed to check compatibility: ${e.message}`);

‎ui/src/app/core/manage-plugins/plugin-compatibility/plugin-compatibility.component.html‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ <h5 class="modal-title">{{ 'plugins.compatibility.title' | translate }}</h5>
1414
<ul class="text-left">
1515
<li *ngIf="!isValidNode">
1616
{{ 'plugins.compatibility.node_too_low' | translate: { pluginName: plugin.name, minVersion: nodeMinVersion, installedVersion: nodeInstalledVersion } }}
17-
<a href="https://homebridge.io/w/JTKEF" target="_blank" rel="noopener noreferrer">How To Update Node.js <i class="fa fa-fw fa-external-link-alt"></i></a>
17+
<a href="https://homebridge.io/w/JTKEF" target="_blank" rel="noopener noreferrer">
18+
{{ 'plugins.compatibility.update_node_link' | translate }} <i class="fa fa-fw fa-external-link-alt"></i>
19+
</a>
1820
</li>
1921
<li *ngIf="!isValidHb">
2022
{{ 'plugins.compatibility.hb_too_low' | translate: { pluginName: plugin.name, minVersion: hbMinVersion, installedVersion: hbInstalledVersion } }}
@@ -29,7 +31,9 @@ <h5 class="modal-title">{{ 'plugins.compatibility.title' | translate }}</h5>
2931
<ul class="text-left">
3032
<li *ngIf="!isValidNode">
3133
{{ 'plugins.compatibility.hb_node_too_low' | translate: { minVersion: nodeMinVersion, installedVersion: nodeInstalledVersion, latestVersion: plugin.latestVersion, packageName: 'Homebridge' } }}
32-
<a href="https://homebridge.io/w/JTKEF" target="_blank" rel="noopener noreferrer">How To Update Node.js <i class="fa fa-fw fa-external-link-alt"></i></a>
34+
<a href="https://homebridge.io/w/JTKEF" target="_blank" rel="noopener noreferrer">
35+
{{ 'plugins.compatibility.update_node_link' | translate }} <i class="fa fa-fw fa-external-link-alt"></i>
36+
</a>
3337
</li>
3438
</ul>
3539
<p>
@@ -43,7 +47,9 @@ <h5 class="modal-title">{{ 'plugins.compatibility.title' | translate }}</h5>
4347
<ul class="text-left">
4448
<li *ngIf="!isValidNode">
4549
{{ 'plugins.compatibility.hb_node_too_low' | translate: { minVersion: nodeMinVersion, installedVersion: nodeInstalledVersion, latestVersion: plugin.latestVersion, packageName: 'Homebridge UI' } }}
46-
<a href="https://homebridge.io/w/JTKEF" target="_blank" rel="noopener noreferrer">How To Update Node.js <i class="fa fa-fw fa-external-link-alt"></i></a>
50+
<a href="https://homebridge.io/w/JTKEF" target="_blank" rel="noopener noreferrer">
51+
{{ 'plugins.compatibility.update_node_link' | translate }} <i class="fa fa-fw fa-external-link-alt"></i>
52+
</a>
4753
</li>
4854
</ul>
4955
<p>

‎ui/src/i18n/bg.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "The {{ pluginName }} plugin recommends running on Node.js v{{ minVersion }} or later. You are currently running Node.js {{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Please upgrade Node.js before updating {{ packageName }}.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "Donate",
197198
"plugins.donate.button_not_verified": "Not Verified",
198199
"plugins.donate.button_verified": "Проверен",

‎ui/src/i18n/ca.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "El plugin {{pluginName}} recomana executar-se en Node.js v{{ minVersion }} o superior. Actualment estàs executant Node.js {{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Si us plau actualitza Node.js abans d'actualitzar {{ packageName }}.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "Donar",
197198
"plugins.donate.button_not_verified": "Not Verified",
198199
"plugins.donate.button_verified": "Verificat",

‎ui/src/i18n/cs.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "Plugin {{ pluginName }} vyžaduje pro běh Homebridge ve verzi v{{ minVersion }} nebo vyšší. Vaše aktuálně běžící verze Homebridge v{{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Před aktualizací {{ packageName }} aktualizujte Node.js.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "Podpořit",
197198
"plugins.donate.button_not_verified": "Not Verified",
198199
"plugins.donate.button_verified": "Ověřeno",

‎ui/src/i18n/de.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "Das {{ pluginName }}-Plugin empfiehlt Homebridge v{{ minVersion }} oder neuer. Du nutzt derzeit Homebridge v{{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Bitte update Node.js, bevor du {{ packageName }} updatest.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "Spenden",
197198
"plugins.donate.button_not_verified": "Nicht verifiziert",
198199
"plugins.donate.button_verified": "Verifiziert",

‎ui/src/i18n/en.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "The {{ pluginName }} plugin recommends running on Node.js v{{ minVersion }} or later. You are currently running Node.js {{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Please upgrade Node.js before updating {{ packageName }}.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "Donate",
197198
"plugins.donate.button_not_verified": "Not Verified",
198199
"plugins.donate.button_verified": "Verified",

‎ui/src/i18n/es.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "El plugin {{ pluginName }} recomienda ejecutarse en Node.js v{{ minVersion }} o superior. Actualmente estás ejecutando Node.js {{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Por favor actualiza Node.js antes de actualizar {{ packageName }}.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "Donar",
197198
"plugins.donate.button_not_verified": "No verificado",
198199
"plugins.donate.button_verified": "Verificado",

‎ui/src/i18n/fr.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "Le plugin {{ pluginName }} recommande l'utilisation de Node.js v{{ minVersion }} ou ultérieur. La version actuellement installée est Node.js {{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Mettez à niveau Node.js avant de mettre à jour {{ packageName }}.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "Faire un don",
197198
"plugins.donate.button_not_verified": "Non Verifié",
198199
"plugins.donate.button_verified": "Verifié",

‎ui/src/i18n/he.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"plugins.compatibility.node_too_low": "The {{ pluginName }} plugin recommends running on Node.js v{{ minVersion }} or later. You are currently running Node.js {{ installedVersion }}.",
194194
"plugins.compatibility.title": "Compatibility Check",
195195
"plugins.compatibility.update_node_first": "Please upgrade Node.js before updating {{ packageName }}.",
196+
"plugins.compatibility.update_node_link": "How To Update Node.js",
196197
"plugins.donate.button_donate": "תרום",
197198
"plugins.donate.button_not_verified": "Not Verified",
198199
"plugins.donate.button_verified": "מְאוּמָת",

0 commit comments

Comments
 (0)