Refactor dockOnStop config option

I think it's clearer as a dropdown

Author: karlvr

config.schema.json

@@ -60,18 +60,22 @@
                 "title": "Home",
                 "required": false
             },
-            "dockOnStop": {
-                "type": "boolean",
-                "title": "Dock when stopped",
-                "default": true,
-                "required": false
+            "stopBehaviour": {
+                "type": "string",
+                "title": "When Roomba is turned off",
+                "required": true,
+                "default": "home",
+                "oneOf": [
+                    { "title": "Home", "enum": ["home"] },
+                    { "title": "Pause", "enum": ["pause"] }
+                ]
             }
         }
     },
     "layout": [
         { "type": "section", "title": "Roomba Details", "items": [ "name", "model", "serialnum", "blid", "robotpwd", "ipaddress" ] },
         { "type": "section", "title": "Contact Sensors", "items": [ "dockContactSensor", "dockingContactSensor", "runningContactSensor", "binContactSensor" ] },
         { "type": "section", "title": "Switches", "items": [ "homeSwitch" ] },
-        { "type": "section", "title": "Behaviour", "items": [ "dockOnStop" ] }
+        { "type": "section", "title": "Behaviour", "items": [ "stopBehaviour" ] }
     ]
 }

src/accessory.ts

@@ -80,7 +80,7 @@ export default class RoombaAccessory implements AccessoryPlugin {
     private robotpwd: string
     private ipaddress: string
     private firmware: string
-    private dockOnStop: boolean
+    private stopBehaviour: "home" | "pause"
 
     private accessoryInfo: Service
     private filterMaintenance: Service
@@ -133,7 +133,7 @@ export default class RoombaAccessory implements AccessoryPlugin {
         this.robotpwd = config.robotpwd;
         this.ipaddress = config.ipaddress;
         this.firmware = "N/A";
-        this.dockOnStop = config.dockOnStop !== undefined ? config.dockOnStop : true;
+        this.stopBehaviour = config.stopBehaviour !== undefined ? config.stopBehaviour : "home";
 
         const showDockAsContactSensor = config.dockContactSensor === undefined ? true : config.dockContactSensor;
         const showRunningAsContactSensor = config.runningContactSensor;
@@ -476,7 +476,7 @@ export default class RoombaAccessory implements AccessoryPlugin {
                         /* Force a refresh of state so we pick up the new state quickly */
                         this.refreshState();
 
-                        if (this.dockOnStop) {
+                        if (this.stopBehaviour === "home") {
                             this.log("Roomba paused, returning to Dock");
                             await this.dockWhenStopped(roomba, 3000);
                         } else {