Remove node-fetch dependency (#212)

Author: ludeeus

package.json

@@ -52,7 +52,6 @@
     "graphql": "^16.6.0",
     "js-yaml": "^4.1.0",
     "nestjs-pino": "^3.1.1",
-    "node-fetch": "2",
     "pino": "^8.4.2",
     "pino-http": "^7.0.0",
     "pino-pretty": "^9.1.0",

services/bots/src/cla-sign/cla-sign.service.ts

@@ -4,7 +4,6 @@ import { Injectable } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
 import { createAppAuth } from '@octokit/auth-app';
 import { DynamoDB } from 'aws-sdk';
-import fetch from 'node-fetch';
 import { GithubClient } from '../github-webhook/github-webhook.model';
 
 export class ServiceRequestError extends ServiceError {}

services/bots/src/discord/commands/home-assistant/versions.ts

@@ -1,6 +1,3 @@
-import fetch from 'node-fetch';
-
-import { getVersionInfo } from '@lib/common';
 import { EmbedBuilder } from 'discord.js';
 import { CommandHandler, DiscordCommandClass } from '../../discord.decorator';
 import {

services/bots/src/discord/services/common/message-data.ts

@@ -1,4 +1,3 @@
-import fetch from 'node-fetch';
 import yaml from 'js-yaml';
 
 import { Injectable } from '@nestjs/common';

services/bots/src/discord/services/esphome/component-data.ts

@@ -1,4 +1,3 @@
-import fetch from 'node-fetch';
 import { Injectable } from '@nestjs/common';
 
 export interface ComponentData {

services/bots/src/discord/services/home-assistant/integration-data.ts

@@ -1,4 +1,3 @@
-import fetch from 'node-fetch';
 import { Injectable } from '@nestjs/common';
 
 export interface IntegrationData {

services/bots/src/discord/services/home-assistant/my-redirect-data.ts

@@ -1,4 +1,3 @@
-import fetch from 'node-fetch';
 import { Injectable } from '@nestjs/common';
 
 interface Redirect {

services/bots/src/github-webhook/handlers/month_of_wth.ts

@@ -1,5 +1,3 @@
-import fetch from 'node-fetch';
-
 import { PullRequest, PullRequestOpenedEvent } from '@octokit/webhooks-types';
 import { EventType, Organization } from '../github-webhook.const';
 import { WebhookContext } from '../github-webhook.model';

services/bots/src/github-webhook/utils/integration.ts

@@ -1,5 +1,3 @@
-import fetch from 'node-fetch';
-
 export enum QualityScale {
   NO_SCORE = 'no score',
   SILVER = 'silver',

tests/services/bots/github-webhook/handlers/issue_comment_commands.spec.ts

@@ -1,23 +1,23 @@
-import fetch from 'node-fetch';
-
 import { WebhookContext } from '../../../../../services/bots/src/github-webhook/github-webhook.model';
 import { mockWebhookContext } from '../../../../utils/test_context';
 import { loadJsonFixture } from '../../../../utils/fixture';
 import { IssueCommentCommands } from '../../../../../services/bots/src/github-webhook/handlers/issue_comment_commands/handler';
 import { IssueCommentCreatedEvent } from '@octokit/webhooks-types';
 import { EventType } from '../../../../../services/bots/src/github-webhook/github-webhook.const';
 
-// Globally mock fetch
-jest.mock('node-fetch', () => jest.fn());
-fetch.mockImplementation(() =>
-  Promise.resolve({ json: () => Promise.resolve({ codeowners: ['@test'] }) }),
-);
-
 describe('IssueCommentCommands', () => {
   let handler: IssueCommentCommands;
   let mockContext: WebhookContext<IssueCommentCreatedEvent>;
+  let mockedFetch: ReturnType<typeof jest.fn>;
 
   beforeEach(function () {
+    mockedFetch = jest.fn(global.fetch);
+    mockedFetch.mockImplementation(() =>
+      Promise.resolve({
+        json: () => Promise.resolve({ codeowners: ['@test'] }),
+      } as unknown as Response),
+    );
+    (global.fetch as unknown) = mockedFetch;
     handler = new IssueCommentCommands();
     mockContext = mockWebhookContext<IssueCommentCreatedEvent>({
       eventType: EventType.ISSUE_COMMENT_CREATED,
@@ -54,7 +54,7 @@ describe('IssueCommentCommands', () => {
       );
     });
     it('not by codeowner', async () => {
-      fetch.mockImplementation(() =>
+      mockedFetch.mockImplementation(() =>
         Promise.resolve({ json: () => Promise.resolve({ codeowners: ['@test'] }) }),
       );
       mockContext.payload.comment.user.login = 'other';