Skip to content

Commit 52dbf67

Browse files
authored
Return server version on validate_server_version (#27)
1 parent cdae9ff commit 52dbf67

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

go2rtc_client/rest.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def __init__(self, websession: ClientSession, server_url: str) -> None:
145145
self.webrtc: Final = _WebRTCClient(self._client)
146146

147147
@handle_error
148-
async def validate_server_version(self) -> None:
148+
async def validate_server_version(self) -> AwesomeVersion:
149149
"""Validate the server version is compatible."""
150150
application_info = await self.application.get_info()
151151
try:
@@ -166,3 +166,5 @@ async def validate_server_version(self) -> None:
166166
_MIN_VERSION_SUPPORTED,
167167
_MIN_VERSION_UNSUPPORTED,
168168
)
169+
170+
return application_info.version

tests/test_rest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ async def test_version_supported(
150150
server_version: str,
151151
expected_result: AbstractContextManager[Any],
152152
) -> None:
153-
"""Test webrtc offer."""
153+
"""Test validate server version."""
154154
payload = json.loads(load_fixture("application_info_answer.json"))
155155
payload["version"] = server_version
156156
responses.get(
@@ -159,7 +159,8 @@ async def test_version_supported(
159159
payload=payload,
160160
)
161161
with expected_result:
162-
await rest_client.validate_server_version()
162+
version = await rest_client.validate_server_version()
163+
assert version == AwesomeVersion(server_version)
163164

164165

165166
async def test_webrtc_offer(

0 commit comments

Comments
 (0)