-
Notifications
You must be signed in to change notification settings - Fork 89
feat: Adds transaction pool funcitonality #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…#4398) Signed-off-by: nikolay <[email protected]>
…olService` interface (#4405) Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]> Signed-off-by: Simeon Nakov <[email protected]> Co-authored-by: Simeon Nakov <[email protected]>
Signed-off-by: nikolay <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> Co-authored-by: Nikolay Atanasow <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: nikolay <[email protected]> Co-authored-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: nikolay <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> Co-authored-by: Konstantina Blazhukova <[email protected]>
# Conflicts: # packages/relay/src/lib/precheck.ts
Test Results 20 files ± 0 269 suites +3 21m 58s ⏱️ +44s Results for commit f908c27. ± Comparison against base commit b7c40e7. This pull request removes 2 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team great work overall! Since this is a big PR it naturally raises quite many questions on my side. I didn’t get a chance to bring them up during the individual PRs, so I’m leaving all my concerns and feedback here. Well tbh having the full picture actually makes it easier to spot things.
Anywho my feedback can be controversial so I’d love to hear your thoughts on them
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
Signed-off-by: Konstantina Blazhukova <[email protected]>
f908c27
aab2f1e to
f908c27
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #4454 +/- ##
==========================================
- Coverage 96.23% 95.52% -0.72%
==========================================
Files 121 127 +6
Lines 20001 20447 +446
Branches 1755 1760 +5
==========================================
+ Hits 19247 19531 +284
- Misses 735 897 +162
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
This PR introduces the new transaction pool feature sitting behind the ENABLE_TX_POOL flag.
The details can be found in the doc create for it https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/4454/files#diff-30f3b82da50d90485c8cddfec36b0a03b7d442dbe7062c07f0c517a8143a387f
Related issue(s)
Fixes #3960
Testing Guide
Additional work needed (optional)
N/A
Checklist