Skip to content

Commit 2a0a2fd

Browse files
Copilotmrlubos
andcommitted
Use v.isoTimeSecond() instead of v.isoTime() for time format
Per feedback from @mrlubos, format: 'time' represents values like 20:20:39+00:00, and Valibot's isoTimeSecond() is a better fit than isoTime(). Co-authored-by: mrlubos <[email protected]>
1 parent 92ebb6b commit 2a0a2fd

File tree

2 files changed

+4
-4
lines changed
  • packages
    • openapi-ts-tests/main/test/__snapshots__/3.1.x/time-format
    • openapi-ts/src/plugins/valibot/v1/toAst

2 files changed

+4
-4
lines changed

packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/time-format/valibot.gen.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ export const vGetSearchData = v.object({
66
body: v.optional(v.never()),
77
path: v.optional(v.never()),
88
query: v.object({
9-
start_time: v.optional(v.pipe(v.string(), v.isoTime())),
10-
end_time: v.pipe(v.string(), v.isoTime())
9+
start_time: v.optional(v.pipe(v.string(), v.isoTimeSecond())),
10+
end_time: v.pipe(v.string(), v.isoTimeSecond())
1111
})
1212
});
1313

@@ -16,5 +16,5 @@ export const vGetSearchData = v.object({
1616
*/
1717
export const vGetSearchResponse = v.object({
1818
result: v.optional(v.string()),
19-
scheduled_time: v.optional(v.pipe(v.string(), v.isoTime()))
19+
scheduled_time: v.optional(v.pipe(v.string(), v.isoTimeSecond()))
2020
});

packages/openapi-ts/src/plugins/valibot/v1/toAst/string.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export const stringToAst = ({
7777
tsc.callExpression({
7878
functionName: tsc.propertyAccessExpression({
7979
expression: v.placeholder,
80-
name: identifiers.actions.isoTime,
80+
name: identifiers.actions.isoTimeSecond,
8181
}),
8282
}),
8383
);

0 commit comments

Comments
 (0)