style: no-var & prefer-const (#3745)

* style: no-var & prefer-const

* refactor: Array.from()

- https://stackoverflow.com/a/38213213

* style: object spacing

* refactor: while() push

Author: curbengh

lib/extend/tag.js

@@ -47,13 +47,10 @@ const placeholder = '\uFFFC';
 const rPlaceholder = /(?:<|&lt;)!--\uFFFC(\d+)--(?:>|&gt;)/g;
 
 function getContextLineNums(min, max, center, amplitude) {
-  var result = [];
-  var lbound = Math.max(min, center - amplitude);
-  var hbound = Math.min(max, center + amplitude);
-  for (var i = lbound; i <= hbound; i++) {
-    result.push(i);
-  }
-
+  const result = [];
+  let lbound = Math.max(min, center - amplitude);
+  const hbound = Math.min(max, center + amplitude);
+  while (lbound <= hbound) result.push(lbound++);
   return result;
 }
 

test/scripts/hexo/multi_config_path.js

@@ -167,7 +167,7 @@ describe('config flag handling', () => {
   });
 
   it('1 not found file warning absolute', () => {
-    let notFile = '/tmp/not_a_file.json';
+    const notFile = '/tmp/not_a_file.json';
 
     mcp(base, notFile).should.eql(pathFn.join(base, '_config.yml'));
     hexo.log.reader[0].type.should.eql('warning');
@@ -256,8 +256,8 @@ describe('config flag handling', () => {
   });
 
   it('write multiconfig to specified path', () => {
-    let outputPath = osFn.tmpdir();
-    let combinedPath = pathFn.join(outputPath, '_multiconfig.yml');
+    const outputPath = osFn.tmpdir();
+    const combinedPath = pathFn.join(outputPath, '_multiconfig.yml');
 
     mcp(base, 'test1.yml', outputPath).should.not.eql(combinedPath);
     mcp(base, 'test1.yml,test2.yml', outputPath).should.eql(combinedPath);