Ignore empty categories/tags. Fix #1704

Author: tommy351

lib/models/post.js

@@ -11,6 +11,14 @@ function pickID(data) {
   return data._id;
 }
 
+function removeEmptyTag(tags) {
+  return tags.filter(function(tag) {
+    return tag != null && tag !== '';
+  }).map(function(tag) {
+    return tag + '';
+  });
+}
+
 module.exports = function(ctx) {
   var Post = new Schema({
     id: String,
@@ -72,6 +80,8 @@ module.exports = function(ctx) {
   });
 
   Post.method('setTags', function(tags) {
+    tags = removeEmptyTag(tags);
+
     var PostTag = ctx.model('PostTag');
     var Tag = ctx.model('Tag');
     var id = this._id;
@@ -121,6 +131,8 @@ module.exports = function(ctx) {
   });
 
   Post.method('setCategories', function(cats) {
+    cats = removeEmptyTag(cats);
+
     var PostCategory = ctx.model('PostCategory');
     var Category = ctx.model('Category');
     var id = this._id;

test/scripts/models/post.js

@@ -203,6 +203,26 @@ describe('Post', function() {
     });
   });
 
+  it('setTags() - empty tag', function() {
+    var id;
+
+    return Post.insert({
+      source: 'foo.md',
+      slug: 'foo'
+    }).then(function(post) {
+      id = post._id;
+      return post.setTags(['', undefined, null, false, 0, 'normal']);
+    }).then(function() {
+      var post = Post.findById(id);
+
+      post.tags.map(function(tag) {
+        return tag.name;
+      }).should.eql(['false', '0', 'normal']);
+    }).finally(function() {
+      return Post.removeById(id);
+    });
+  });
+
   it('setCategories() - old categories should be removed', function() {
     var id;
 
@@ -304,6 +324,46 @@ describe('Post', function() {
     });
   });
 
+  it('setCategories() - empty category', function() {
+    var id;
+
+    return Post.insert({
+      source: 'foo.md',
+      slug: 'foo'
+    }).then(function(post) {
+      id = post._id;
+      return post.setCategories(['test', null]);
+    }).then(function() {
+      var post = Post.findById(id);
+
+      post.categories.map(function(cat) {
+        return cat.name;
+      }).should.eql(['test']);
+    }).finally(function() {
+      return Post.removeById(id);
+    });
+  });
+
+  it('setCategories() - empty category in middle', function() {
+    var id;
+
+    return Post.insert({
+      source: 'foo.md',
+      slug: 'foo'
+    }).then(function(post) {
+      id = post._id;
+      return post.setCategories(['foo', null, 'bar']);
+    }).then(function() {
+      var post = Post.findById(id);
+
+      post.categories.map(function(cat) {
+        return cat.name;
+      }).should.eql(['foo', 'bar']);
+    }).finally(function() {
+      return Post.removeById(id);
+    });
+  });
+
   it('remove PostTag references when a post is removed', function() {
     return Post.insert({
       source: 'foo.md',