Merge pull request #3986 from curbengh/chain-assignment

style: chained assignment

Author: SukkaW

lib/extend/console.js

@@ -53,7 +53,8 @@ Console.prototype.register = function(name, desc, options, fn) {
   }
 
   const c = fn;
-  this.store[name.toLowerCase()] = fn;
+
+  this.store[name.toLowerCase()] = c;
   c.options = options;
   c.desc = desc;
 

lib/extend/filter.js

@@ -31,8 +31,8 @@ class Filter {
     type = typeAlias[type] || type;
     priority = priority == null ? 10 : priority;
 
-    this.store[type] = this.store[type] || [];
     const store = this.store[type] || [];
+    this.store[type] = store;
 
     fn.priority = priority;
     store.push(fn);

lib/hexo/index.js

@@ -473,12 +473,12 @@ class Hexo {
 inherits(Hexo, EventEmitter);
 
 Hexo.lib_dir = libDir + sep;
-Hexo.prototype.lib_dir = libDir + sep;
+Hexo.prototype.lib_dir = Hexo.lib_dir;
 
 Hexo.core_dir = dirname(libDir) + sep;
-Hexo.prototype.core_dir = dirname(libDir) + sep;
+Hexo.prototype.core_dir = Hexo.core_dir;
 
 Hexo.version = version;
-Hexo.prototype.version = version;
+Hexo.prototype.version = Hexo.version;
 
 module.exports = Hexo;

lib/hexo/locals.js

@@ -16,7 +16,7 @@ class Locals {
       if (!getter) return;
 
       cache = getter();
-      this.cache[name] = getter();
+      this.cache[name] = cache;
     }
 
     return cache;

lib/hexo/router.js

@@ -32,7 +32,7 @@ const format = path => {
 };
 
 Router.format = format;
-Router.prototype.format = format;
+Router.prototype.format = Router.format;
 
 Router.prototype.list = function() {
   const { routes } = this;

lib/theme/index.js

@@ -36,7 +36,7 @@ class Theme extends Box {
     };
 
     const _View = viewFn;
-    this.View = viewFn;
+    this.View = _View;
 
     inherits(_View, View);
 
@@ -66,7 +66,7 @@ class Theme extends Box {
     const ext = extname(path);
     const name = path.substring(0, path.length - ext.length);
     this.views[name] = this.views[name] || {};
-    const views = this.views[name] || {};
+    const views = this.views[name];
 
     views[ext] = new this.View(path, data);
   }