Taking out options mangling for Search

Author: Matt Kirk

lib/linked_in/search.rb

@@ -1,6 +1,7 @@
 module LinkedIn
 
   module Search
+    REJECT_KEYS = [:fields]
 
     # Retrieve search results of the given object type
     #
@@ -21,23 +22,37 @@ def search(options={}, type='people')
       path = "#{type.to_s}-search"
 
       if options.is_a?(Hash)
-        fields = options.delete(:fields)
-        path += field_selector(fields) if fields
+        fields = options.fetch(:fields, [])
+        if !fields.empty?
+          path += field_selector(fields)
+        else
+
+        end
+      elsif options.is_a?(String)
+        options = {:keywords => options}
+      else
+
       end
 
-      options = { :keywords => options } if options.is_a?(String)
       options = format_options_for_query(options)
       get(path, options)
     end
 
     private
 
       def format_options_for_query(opts)
-        opts.inject({}) do |list, kv|
-          key, value = kv.first.to_s.gsub("_","-"), kv.last
-          list[key]  = sanitize_value(value)
-          list
+        query_hash = {}
+
+        opts.each do |k, value|
+          if REJECT_KEYS.include?(k)
+            next
+          else
+            key = k.to_s.gsub("_", "-")
+            query_hash[key] = sanitize_value(value)
+          end
         end
+
+        query_hash
       end
 
       def sanitize_value(value)

spec/cases/search_spec.rb

@@ -77,9 +77,18 @@
 
     describe "by keywords options with fields", vcr: vcr_options do
 
+      let(:fields) { [{:companies => [:id, :name, :industries, :description, :specialties]}, :num_results] }
+      let(:options) { {:keywords => 'apple', :fields => fields} }
+
       let(:results) do
-        fields = [{:companies => [:id, :name, :industries, :description, :specialties]}, :num_results]
-        client.search({:keywords => 'apple', :fields => fields}, 'company')
+        client.search(options, 'company')
+      end
+
+      it "doesn't change the original options" do
+        original_options = options.dup
+        client.search(options, 'company')
+
+        options.should == original_options
       end
 
       it "should perform a search" do