Fix accounts test, add back other lib tests

Author: eablack

packages/cli/src/lib/accounts/accounts.ts

@@ -1,7 +1,7 @@
 import {parse, stringify} from 'yaml'
-import * as fs from 'fs'
-import * as os from 'node:os'
-import * as path from 'node:path'
+import fs from 'node:fs'
+import os from 'node:os'
+import path from 'node:path'
 import * as Heroku from '@heroku-cli/schema'
 
 export interface IAccountsWrapper {

packages/cli/test/unit/lib/addons/resolve.unit.test.ts

@@ -1,11 +1,10 @@
 import {resolveAddon, appAddon} from '../../../../src/lib/addons/resolve.js'
 import {getHerokuAPI} from '../../../helpers/testInstances.js'
 import {expect} from 'chai'
-import * as nock from 'nock'
+import nock from 'nock'
 import * as Heroku from '@heroku-cli/schema'
 import {APIClient} from '@heroku-cli/command'
 
-/*
 describe('resolve', function () {
   let herokuAPI: APIClient
 
@@ -90,7 +89,7 @@ describe('resolve', function () {
         })
     })
 
-    it('fails if no addon found', function () {
+    it('fails if no addon found with an addon service', function () {
       const api = nock('https://api.heroku.com:443')
         .post('/actions/addons/resolve', {app: 'myapp', addon: 'myaddon-3', addon_service: 'slowdb'}).reply(404, {resource: 'add_on'})
         .post('/actions/addons/resolve', {app: null, addon: 'myaddon-3', addon_service: 'slowdb'}).reply(404, {resource: 'add_on'})
@@ -306,5 +305,3 @@ describe('resolve', function () {
     })
   })
 })
-
-*/

packages/cli/test/unit/lib/addons/util.unit.test.ts

@@ -1,7 +1,6 @@
 import * as util from '../../../../src/lib/addons/util.js'
 import {expect} from 'chai'
 
-/*
 describe('util.formatPrice', function () {
   it('formats as "free" when cents is 0', function () {
     expect(util.formatPrice({price: {cents: 0}, hourly: false})).to.eq('free')
@@ -33,5 +32,3 @@ describe('util.formatPrice', function () {
     })
   })
 })
-
-*/

packages/cli/test/unit/lib/apps/generation.unit.test.ts

@@ -1,10 +1,9 @@
 import {expect} from 'chai'
 import {APIClient} from '@heroku-cli/command'
 import nock from 'nock'
-// import {getGeneration, getGenerationByAppId} from '../../../../src/lib/apps/generation'
+import {getGeneration, getGenerationByAppId} from '../../../../src/lib/apps/generation.js'
 import {Config} from '@oclif/core'
 
-/*
 describe('generation', function () {
   describe('getGeneration', function () {
     it('identifies fir generation from string format web-xxxxxxxxx-xxxxx', function () {
@@ -81,5 +80,3 @@ describe('generation', function () {
     })
   })
 })
-
-*/

packages/cli/test/unit/lib/authorizations/authorizations.unit.test.ts

@@ -8,7 +8,6 @@ const setupDisplay = (auth: Heroku.OAuthAuthorization) =>
     .stdout()
     .do(() => display(auth))
 
-/*
 describe('display', function () {
   const authId = 'f6e8d969-129f-42d2-854b-c2eca9d5a42e'
   const authDesc = 'a cool auth'
@@ -94,5 +93,3 @@ describe('display', function () {
       })
   })
 })
-
-*/

packages/cli/test/unit/lib/ci/pipelines.unit.test.ts

@@ -10,7 +10,6 @@ const PIPELINE = {
 }
 const FLAGS = {pipeline: PIPELINE.id}
 
-/*
 describe('pipelines.ts', function () {
   let herokuAPI: APIClient
 
@@ -48,5 +47,3 @@ describe('pipelines.ts', function () {
     })
   })
 })
-
-*/

packages/cli/test/unit/lib/clients/clients.unit.test.ts

@@ -2,7 +2,6 @@ import {expect, test} from '@oclif/test'
 
 import {validateURL} from '../../../../src/lib/clients/clients.js'
 
-/*
 describe('validateURL', function () {
   describe('secure URLs', function () {
     [
@@ -49,5 +48,3 @@ describe('validateURL', function () {
     })
   })
 })
-
-*/

packages/cli/test/unit/lib/config/quote.test.ts

@@ -1,8 +1,7 @@
 import {expect} from 'chai'
 
-import {parse, quote} from '../../../lib/config/quote.js'
+import {parse, quote} from '../../../../src/lib/config/quote.js'
 
-/*
 describe('quote', function () {
   [
     ['abc', 'abc'],
@@ -28,5 +27,3 @@ describe('quote', function () {
     })
   })
 })
-
-*/