chore: enable more Ruff checks (#126)

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

.pre-commit-config.yaml

@@ -50,7 +50,7 @@ repos:
         additional_dependencies:
           - tomli
           - pathspec
-          - pytest
+          - pytest<9 # pytest 9 requires Python 3.10+
           - validate-pyproject
           - uv
 

pyproject.toml

@@ -105,35 +105,21 @@ disallow_incomplete_defs = true
 
 
 [tool.ruff.lint]
-extend-select = [
-  "B",           # flake8-bugbear
-  "I",           # isort
-  "ARG",         # flake8-unused-arguments
-  "C4",          # flake8-comprehensions
-  "EM",          # flake8-errmsg
-  "ICN",         # flake8-import-conventions
-  "ISC",         # flake8-implicit-str-concat
-  "G",           # flake8-logging-format
-  "PGH",         # pygrep-hooks
-  "PIE",         # flake8-pie
-  "PL",          # pylint
-  "PT",          # flake8-pytest-style
-  "PTH",         # flake8-use-pathlib
-  "RET",         # flake8-return
-  "RUF",         # Ruff-specific
-  "SIM",         # flake8-simplify
-  "UP",          # pyupgrade
-  "YTT",         # flake8-2020
-  "EXE",         # flake8-executable
-]
+select = ["ALL"]
 ignore = [
   "PLR09",  # Design related pylint codes
   "E501",   # Line too long
-  "ISC001", # Conflicts with formatter
+  "COM",    # Trailing commas teach the formatter
+  "S",      # Security related checks go too far (no assert, for example)
+  "D",      # Too many docstring warnings
+  "T20",    # Print is intentional here
 ]
 flake8-unused-arguments.ignore-variadic-names = true
 isort.required-imports = ["from __future__ import annotations"]
 
+[tool.ruff.lint.per-file-ignores]
+"tests/*" = ["ANN201", "INP"]
+
 
 [tool.pylint]
 py-version = "3.9"

src/check_sdist/__main__.py

@@ -2,9 +2,8 @@
 
 import argparse
 import contextlib
-from collections.abc import Sequence
 from pathlib import Path
-from typing import Literal
+from typing import TYPE_CHECKING, Literal
 
 import pathspec
 
@@ -16,6 +15,9 @@
 from .resources import resources
 from .sdist import get_uv, sdist_files
 
+if TYPE_CHECKING:
+    from collections.abc import Sequence
+
 
 def select_installer(
     installer: Literal["pip", "uv", "uv|pip"],

src/check_sdist/git.py

@@ -4,7 +4,7 @@
 from pathlib import Path
 
 
-def git_files(source_dir: Path, recurse_submodules: bool = True) -> frozenset[str]:
+def git_files(source_dir: Path, *, recurse_submodules: bool = True) -> frozenset[str]:
     """Return the files that are tracked by git in the source directory."""
 
     cmd = ["git", "ls-files", "--cached"]

src/check_sdist/inject.py

@@ -2,11 +2,14 @@
 
 import contextlib
 import sys
-from collections.abc import Generator, Sequence
-from pathlib import Path
+from typing import TYPE_CHECKING
 
 from .resources import resources
 
+if TYPE_CHECKING:
+    from collections.abc import Generator, Sequence
+    from pathlib import Path
+
 __all__ = ["inject_files", "inject_junk_files"]
 
 

tests/test_cli.py

@@ -6,7 +6,7 @@
 from check_sdist.__main__ import main
 
 
-def test_version(capsys):
+def test_version(capsys: pytest.CaptureFixture[str]):
     with pytest.raises(SystemExit):
         main(["--version"])
 

tests/test_downstream.py

@@ -3,6 +3,7 @@
 import subprocess
 import sys
 from pathlib import Path
+from typing import Literal
 
 import pytest
 
@@ -28,7 +29,14 @@
 @pytest.mark.parametrize(
     ("repo", "ref", "fail"), [(x["repo"], x["ref"], x.get("fail", 0)) for x in packages]
 )
-def test_packages(repo, ref, fail, tmp_path, monkeypatch, installer):
+def test_packages(
+    repo: str,
+    ref: str,
+    fail: int,
+    tmp_path: Path,
+    monkeypatch: pytest.MonkeyPatch,
+    installer: Literal["uv", "pip"],
+):
     if repo.endswith("scikit-build") and sys.platform.startswith("win32"):
         pytest.skip(reason="Path too long on Windows (0.18)")
 

tests/test_inject.py

@@ -1,9 +1,12 @@
 from __future__ import annotations
 
-from pathlib import Path
+from typing import TYPE_CHECKING
 
 from check_sdist.inject import inject_files, inject_junk_files
 
+if TYPE_CHECKING:
+    from pathlib import Path
+
 
 def test_inject_files(tmp_path: Path):
     with inject_files(tmp_path, ["a", "b", "c/", "d/e", "f/g/"]):