Return static strings

Author: danieljharvey

crates/sdk-core/src/connector.rs

@@ -44,9 +44,9 @@ pub trait Connector: Send + 'static {
     /// The type of unserializable state
     type State: Send + Sync;
 
-    fn connector_name() -> String;
+    fn connector_name() -> &'static str;
 
-    fn connector_version() -> String;
+    fn connector_version() -> &'static str;
 
     /// Update any metrics from the state
     ///

crates/sdk-core/src/connector/example.rs

@@ -34,12 +34,12 @@ impl Connector for Example {
     type Configuration = ();
     type State = ();
 
-    fn connector_name() -> String {
-        "example".into()
+    fn connector_name() -> &'static str {
+        "example"
     }
 
-    fn connector_version() -> String {
-        "1.0.0".into()
+    fn connector_version() -> &'static str {
+        env!("CARGO_PKG_VERSION")
     }
 
     fn fetch_metrics(_configuration: &Self::Configuration, _state: &Self::State) -> Result<()> {

crates/sdk/src/tracing.rs

@@ -17,8 +17,8 @@ static CONNECTOR_VERSION: &str = "service.connector.version";
 pub fn init_tracing(
     service_name: Option<&str>,
     otlp_endpoint: Option<&str>,
-    connector_name: String,
-    connector_version: String,
+    connector_name: &str,
+    connector_version: &str,
 ) -> Result<(), Box<dyn Error + Send + Sync>> {
     let trace_endpoint = otlp_endpoint
         .map(ToOwned::to_owned)