fix: don't try to fetch channels in gw events as it causes undefined behavior for serverless bots

Author: DjDeveloperr

src/gateway/handlers/messageCreate.ts

@@ -9,10 +9,11 @@ export const messageCreate: GatewayEventHandler = async (
   d: MessagePayload
 ) => {
   let channel = await gateway.client.channels.get<TextChannel>(d.channel_id)
-  // Fetch the channel if not cached
-  if (channel === undefined)
-    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
-    channel = (await gateway.client.channels.fetch(d.channel_id)) as TextChannel
+  // Fetch the channel if not cached.
+  // Commented out right now as it causes some undefined behavior.
+  // if (channel === undefined)
+  //   // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+  //   channel = (await gateway.client.channels.fetch(d.channel_id)) as TextChannel
   if (channel === undefined) return
   await channel.messages.set(d.id, d)
   const user = new User(gateway.client, d.author)

src/gateway/handlers/messageDelete.ts

@@ -7,10 +7,9 @@ export const messageDelete: GatewayEventHandler = async (
   d: MessageDeletePayload
 ) => {
   let channel = await gateway.client.channels.get<TextChannel>(d.channel_id)
-  // Fetch the channel if not cached
-  if (channel === undefined)
-    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
-    channel = (await gateway.client.channels.fetch(d.channel_id)) as TextChannel
+  // if (channel === undefined)
+  //   // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+  //   channel = (await gateway.client.channels.fetch(d.channel_id)) as TextChannel
   if (channel === undefined) return
   const message = await channel.messages.get(d.id)
   if (message === undefined)

src/gateway/handlers/messageDeleteBulk.ts

@@ -12,11 +12,11 @@ export const messageDeleteBulk: GatewayEventHandler = async (
     d.channel_id
   )
   // Fetch the channel if not cached
-  if (channel === undefined)
-    // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
-    channel = (await gateway.client.channels.fetch(
-      d.channel_id
-    )) as GuildTextBasedChannel
+  // if (channel === undefined)
+  //   // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+  //   channel = (await gateway.client.channels.fetch(
+  //     d.channel_id
+  //   )) as GuildTextBasedChannel
   if (channel === undefined) return
   const messages = new Collection<string, Message>()
   const uncached = new Set<string>()

src/gateway/handlers/messageUpdate.ts

@@ -8,9 +8,8 @@ export const messageUpdate: GatewayEventHandler = async (
   d: MessagePayload
 ) => {
   let channel = await gateway.client.channels.get<TextChannel>(d.channel_id)
-  // Fetch the channel if not cached
-  if (channel === undefined)
-    channel = await gateway.client.channels.fetch(d.channel_id)
+  // if (channel === undefined)
+  //   channel = await gateway.client.channels.fetch(d.channel_id)
 
   if (channel === undefined) return