chore: upgrade to Go 1.25.0 (GoogleContainerTools#9859)

* chore: upgrade to Go 1.24.6

* chore: upgrade to Go 1.25.0

* fix: remove @ GOEXPERIMENT=nocoverageredesign env var

* fix: fix getHandleFromProcess error

* testing to see what type handle is

* testing to see what type handle is

* fix Windows handle panic

Author: menahyouyeah

.github/workflows/integration-linux.yml

@@ -35,7 +35,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.24.2
+        go-version: 1.25.0
       id: go
 
     - name: Set up Java

.github/workflows/linters-checks.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.24.2
+          go-version: 1.25.0
         id: go
 
       - name: Check out code into the Go module directory

.github/workflows/unit-tests-darwin.yml

@@ -23,7 +23,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.24.2
+        go-version: 1.25.0
       id: go
 
     # Retrieve build locations with `go env`

.github/workflows/unit-tests-linux.yml

@@ -17,7 +17,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.24.2
+        go-version: 1.25.0
       id: go
 
     - name: Check out code into the Go module directory

.github/workflows/unit-tests-windows.yml

@@ -24,7 +24,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.24.2
+        go-version: 1.25.0
       id: go
 
     # Retrieve build locations with `go env`

.github/workflows/verify-examples.yml

@@ -23,7 +23,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.24.2
+        go-version: 1.25.0
       id: go
 
     # Skip changes not affecting examples or integration/examples

Makefile

@@ -122,7 +122,7 @@ unit-tests: $(BUILD_DIR)
 .PHONY: coverage
 coverage: $(BUILD_DIR)
     # https://go-review.git.corp.google.com/c/go/+/569575
-	@ GOEXPERIMENT=nocoverageredesign ./hack/gotest.sh -count=1 -race -cover -short -timeout=90s -coverprofile=out/coverage.txt -coverpkg="./pkg/...,./cmd/..." $(SKAFFOLD_TEST_PACKAGES)
+	@ ./hack/gotest.sh -count=1 -race -cover -short -timeout=90s -coverprofile=out/coverage.txt -coverpkg="./pkg/...,./cmd/..." $(SKAFFOLD_TEST_PACKAGES)
 	@- curl -s https://codecov.io/bash > $(BUILD_DIR)/upload_coverage && bash $(BUILD_DIR)/upload_coverage
 
 .PHONY: checks

deploy/skaffold/Dockerfile.deps

@@ -163,5 +163,5 @@ RUN apt-get update && apt-get install --no-install-recommends --no-install-sugge
     jq \
     apt-transport-https && \
     rm -rf /var/lib/apt/lists/*
-COPY --from=golang:1.24.2 /usr/local/go /usr/local/go
+COPY --from=golang:1.25.0 /usr/local/go /usr/local/go
 ENV PATH /usr/local/go/bin:/root/go/bin:$PATH

pkg/skaffold/kubectl/exec_windows.go

@@ -83,7 +83,8 @@ func (c *Cmd) Start() error {
 }
 
 func getHandleFromProcess(p *os.Process) (windows.Handle, error) {
-	// `os.Process` don't expose `handle uintptr` field.
+	// os.Process contains an unexported processHandle struct, which contains
+	// a `handle uintptr` field.
 	v := reflect.ValueOf(p)
 	i := reflect.Indirect(v)
 
@@ -96,8 +97,11 @@ func getHandleFromProcess(p *os.Process) (windows.Handle, error) {
 	if f.IsZero() {
 		return windows.InvalidHandle, fmt.Errorf("could not get 'handle' field from os.Process. probably a bug")
 	}
+	// Get the processHandle struct
+	handlestruct := reflect.Indirect(f)
+	handle := handlestruct.FieldByName("handle")
 
-	return windows.Handle(f.Uint()), nil
+	return windows.Handle(handle.Uint()), nil
 }
 
 // Run starts the specified command in a job object and waits for it to complete