vector: bug fix: paths were unexpectedly clipped

Closes #3357

Author: hajimehoshi

vector/atlas.go

@@ -104,6 +104,7 @@ func (a *atlas) setPaths(dstBounds image.Rectangle, paths []*Path, antialias boo
 		var currentPosition image.Point
 		for i := range a.atlasRegions {
 			pb := a.pathRenderingBounds[a.atlasRegions[i].pathIndex]
+			// TODO: What if s already exceeds maxImageSize (#3357)?
 			s := pb.Size()
 			// An additional image for antialiasing must be on the same atlas,
 			// so extend the width and use it as a sub image.
@@ -113,15 +114,14 @@ func (a *atlas) setPaths(dstBounds image.Rectangle, paths []*Path, antialias boo
 			if i == 0 {
 				currentRowHeight = s.Y
 			} else if currentPosition.X+s.X > maxImageSize {
+				// Try the next row.
 				currentPosition.X = 0
+				currentPosition.Y += currentRowHeight
 				if currentPosition.Y+s.Y > maxImageSize {
 					atlasImageIndex++
 					a.atlasSizes = append(a.atlasSizes, image.Point{})
 					currentPosition.Y = 0
-				} else {
-					currentPosition.Y += currentRowHeight
 				}
-				currentRowHeight = s.Y
 			}
 			a.atlasRegions[i].imageIndex = atlasImageIndex
 			a.atlasRegions[i].imageBounds = image.Rectangle{

vector/util_test.go

@@ -196,3 +196,32 @@ func TestFillPathSubImageAndImage(t *testing.T) {
 		}
 	}
 }
+
+// Issue #3357
+func TestFillRects(t *testing.T) {
+	dsts := []*ebiten.Image{
+		ebiten.NewImage(1920, 1080),
+		ebiten.NewImage(1920, 1080),
+	}
+	for _, dst := range dsts {
+		defer dst.Deallocate()
+	}
+
+	for i, antialias := range []bool{true, false} {
+		dst := dsts[i]
+		vector.FillRect(dst, 593, -609, 1144, 1969, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+		vector.FillRect(dst, 613, -146, 1124, 446, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+		vector.FillRect(dst, 634, -80, 1103, 190, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+		vector.FillRect(dst, 634, 110, 1103, 190, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+		vector.FillRect(dst, 613, 300, 1124, 998, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+		vector.FillRect(dst, 634, 433, 1104, 865, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+		vector.FillRect(dst, 654, 495, 1084, 741, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+		vector.FillRect(dst, 674, 592, 1063, 644, color.RGBA{0x10, 0x00, 0x00, 0x10}, antialias)
+	}
+
+	got := dsts[0].At(800, 0)
+	want := dsts[1].At(800, 0)
+	if got != want {
+		t.Errorf("got: %v, want: %v", got, want)
+	}
+}