Merge pull request quarkusio#49847 from geoand/jackson-nsfe-hang

Catch Throwable in ApplicationLifecycleManager

Author: geoand

core/runtime/src/main/java/io/quarkus/runtime/ApplicationLifecycleManager.java

@@ -164,8 +164,8 @@ public static void run(Application application, Class<? extends QuarkusApplicati
                     stateLock.unlock();
                 }
             }
-        } catch (Exception e) {
-            Throwable rootCause = ExceptionUtil.getRootCause(e);
+        } catch (Throwable t) {
+            Throwable rootCause = ExceptionUtil.getRootCause(t);
             if (exitCodeHandler == null) {
                 Logger applicationLogger = Logger.getLogger(Application.class);
                 if (rootCause instanceof QuarkusBindException qbe) {
@@ -198,7 +198,7 @@ public static void run(Application application, Class<? extends QuarkusApplicati
                         && !StringUtil.isNullOrEmpty(rootCause.getMessage())) {
                     System.err.println(rootCause.getMessage());
                 } else {
-                    applicationLogger.errorv(e, "Failed to start application");
+                    applicationLogger.errorv(t, "Failed to start application");
                     ensureConsoleLogsDrained();
                 }
             }
@@ -214,7 +214,7 @@ public static void run(Application application, Class<? extends QuarkusApplicati
                     ? ((PreventFurtherStepsException) rootCause).getExitCode()
                     : 1;
             currentApplication = null;
-            (exitCodeHandler == null ? defaultExitCodeHandler : exitCodeHandler).accept(exceptionExitCode, e);
+            (exitCodeHandler == null ? defaultExitCodeHandler : exitCodeHandler).accept(exceptionExitCode, t);
             return;
         } finally {
             try {

integration-tests/test-extension/tests/src/main/java/io/quarkus/it/testsupport/commandmode/FailingApp.java

@@ -0,0 +1,18 @@
+package io.quarkus.it.testsupport.commandmode;
+
+import io.quarkus.runtime.QuarkusApplication;
+import io.quarkus.runtime.annotations.QuarkusMain;
+
+/*
+ * Because this app co-exists in a module with a QuarkusIntegrationTest, it needs to not be on the default path.
+ * Otherwise, this application is executed by the QuarkusIntegrationTest and exits early, causing test failures elsewhere.
+ */
+@QuarkusMain(name = "failing-application")
+public class FailingApp implements QuarkusApplication {
+
+    @Override
+    public int run(String... args) throws Exception {
+        // the point of this is to verify that Quarkus can properly shut down in the face of an Error (not an Exception)
+        throw new NoSuchMethodError("dummy");
+    }
+}

integration-tests/test-extension/tests/src/test/java/io/quarkus/it/testsupport/commandmode/QuarkusMainTestWithTestProfileAndFailingApplicationTestCase.java

@@ -0,0 +1,32 @@
+package io.quarkus.it.testsupport.commandmode;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.Map;
+
+import org.junit.jupiter.api.Test;
+
+import io.quarkus.test.junit.QuarkusTestProfile;
+import io.quarkus.test.junit.TestProfile;
+import io.quarkus.test.junit.main.Launch;
+import io.quarkus.test.junit.main.LaunchResult;
+import io.quarkus.test.junit.main.QuarkusMainTest;
+
+@QuarkusMainTest
+@TestProfile(QuarkusMainTestWithTestProfileAndFailingApplicationTestCase.MyTestProfile.class)
+public class QuarkusMainTestWithTestProfileAndFailingApplicationTestCase {
+
+    @Test
+    @Launch(value = {}, exitCode = 1)
+    public void testLaunchCommand(LaunchResult result) {
+        assertThat(result.getOutput()).contains("dummy");
+    }
+
+    public static class MyTestProfile implements QuarkusTestProfile {
+
+        @Override
+        public Map<String, String> getConfigOverrides() {
+            return Map.of("quarkus.package.main-class", "failing-application");
+        }
+    }
+}