Skip to content

Commit bef870d

Browse files
committed
AttachLinkOrFileDialog: Feature support image attachment to use image syntax, closes #2651, by @gsantner
1 parent fd81a6c commit bef870d

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

app/src/main/java/net/gsantner/markor/frontend/AttachLinkOrFileDialog.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import net.gsantner.opoc.format.GsTextUtils;
3838
import net.gsantner.opoc.frontend.filebrowser.GsFileBrowserListAdapter;
3939
import net.gsantner.opoc.frontend.filebrowser.GsFileBrowserOptions;
40+
import net.gsantner.opoc.util.GsContextUtils;
4041
import net.gsantner.opoc.util.GsFileUtils;
4142
import net.gsantner.opoc.wrapper.GsCallback;
4243

@@ -298,14 +299,10 @@ private static String setupFileAttachment(
298299
return path;
299300
}
300301

301-
public static String makeAttachmentLink(
302-
final int textFormatId,
303-
final String title,
304-
final File attachment,
305-
final File document
306-
) {
302+
public static String makeAttachmentLink(final int textFormatId, final String title, final File attachment, final File document) {
307303
final String path = setupFileAttachment(textFormatId, attachment, document, AppSettings.get(null));
308-
return formatLink(title, path, textFormatId);
304+
final boolean isImage = GsFileUtils.getMimeType(attachment).contains("image");
305+
return formatLink(title, path, textFormatId, isImage ? InsertType.IMAGE_DIALOG : InsertType.LINK_DIALOG);
309306
}
310307

311308
private static void fetchAndInsertItem(

0 commit comments

Comments
 (0)