Upgrade to Checkstyle 8.28

Trying to upgrade Gradle to 7.6 improved the checkstyle plugin such that
it appears to have been running in new occasions. That in turn exposed
us to checkstyle/checkstyle#5088. That bug was
fixed in 8.28, which also fixed lots of other bugs. So now we have
better checking and some existing volations needed fixing. Since the
code style fixes generated a lot of noise, this is a pre-fix to reduce
the size of a Gradle upgrade.

I did not upgrade past 8.28 because at some point some other bugs were
introduced, in particular with the Indentation module. I chose the
oldest version that had the particular bug impacting me fixed. Upgrading
to this old-but-newer version still makes it easier to upgrade to a
newer version in the future.

Author: ejona86

alts/src/main/java/io/grpc/alts/AltsContextUtil.java

@@ -26,7 +26,7 @@
 @ExperimentalApi("https://github.com/grpc/grpc-java/issues/7864")
 public final class AltsContextUtil {
 
-  private AltsContextUtil(){}
+  private AltsContextUtil() {}
 
   /**
    * Creates a {@link AltsContext} from ALTS context information in the {@link ServerCall}.

alts/src/main/java/io/grpc/alts/internal/AltsTsiHandshaker.java

@@ -169,7 +169,7 @@ public void getBytesToSendToPeer(ByteBuffer bytes) throws GeneralSecurityExcepti
   }
 
   /**
-   * Returns true if and only if the handshake is still in progress
+   * Returns true if and only if the handshake is still in progress.
    *
    * @return true, if the handshake is still in progress, false otherwise.
    */

alts/src/main/java/io/grpc/alts/internal/NettyTsiHandshaker.java

@@ -99,7 +99,7 @@ boolean processBytesFromPeer(ByteBuf data) throws GeneralSecurityException {
   }
 
   /**
-   * Returns true if and only if the handshake is still in progress
+   * Returns true if and only if the handshake is still in progress.
    *
    * @return true, if the handshake is still in progress, false otherwise.
    */

alts/src/main/java/io/grpc/alts/internal/TsiHandshaker.java

@@ -68,7 +68,7 @@ public interface TsiHandshaker {
   boolean processBytesFromPeer(ByteBuffer bytes) throws GeneralSecurityException;
 
   /**
-   * Returns true if and only if the handshake is still in progress
+   * Returns true if and only if the handshake is still in progress.
    *
    * @return true, if the handshake is still in progress, false otherwise.
    */

api/src/main/java/io/grpc/Metadata.java

@@ -834,7 +834,7 @@ public String toString() {
     abstract T parseBytes(byte[] serialized);
 
     /**
-     * @return whether this key will be serialized to bytes lazily.
+     * Returns whether this key will be serialized to bytes lazily.
      */
     boolean serializesToStreams() {
       return false;

api/src/main/java/io/grpc/NameResolver.java

@@ -205,6 +205,8 @@ void onAddresses(
   @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1770")
   public abstract static class Listener2 implements Listener {
     /**
+     * Handles updates on resolved addresses and attributes.
+     *
      * @deprecated This will be removed in 1.22.0
      */
     @Override

api/src/main/java/io/grpc/Status.java

@@ -599,6 +599,8 @@ private static boolean isEscapingChar(byte b) {
     }
 
     /**
+     * Percent encode bytes to make them ASCII.
+     *
      * @param valueBytes the UTF-8 bytes
      * @param ri The reader index, pointed at the first byte that needs escaping.
      */

authz/src/test/java/io/grpc/authz/AuthorizationEnd2EndTest.java

@@ -35,7 +35,6 @@
 import io.grpc.testing.protobuf.SimpleRequest;
 import io.grpc.testing.protobuf.SimpleResponse;
 import io.grpc.testing.protobuf.SimpleServiceGrpc;
-
 import java.io.File;
 import org.junit.After;
 import org.junit.Test;

benchmarks/src/jmh/java/io/grpc/benchmarks/TransportBenchmark.java

@@ -87,23 +87,20 @@ public void setUp() throws Exception {
     ServerBuilder<?> serverBuilder;
     ManagedChannelBuilder<?> channelBuilder;
     switch (transport) {
-      case INPROCESS:
-      {
+      case INPROCESS: {
         String name = "bench" + Math.random();
         serverBuilder = InProcessServerBuilder.forName(name);
         channelBuilder = InProcessChannelBuilder.forName(name);
         break;
       }
-      case NETTY:
-      {
+      case NETTY: {
         InetSocketAddress address = new InetSocketAddress("localhost", pickUnusedPort());
         serverBuilder = NettyServerBuilder.forAddress(address, serverCreds);
         channelBuilder = NettyChannelBuilder.forAddress(address)
             .negotiationType(NegotiationType.PLAINTEXT);
         break;
       }
-      case NETTY_LOCAL:
-      {
+      case NETTY_LOCAL: {
         String name = "bench" + Math.random();
         LocalAddress address = new LocalAddress(name);
         EventLoopGroup group = new DefaultEventLoopGroup();
@@ -118,8 +115,7 @@ public void setUp() throws Exception {
         groupToShutdown = group;
         break;
       }
-      case NETTY_EPOLL:
-      {
+      case NETTY_EPOLL: {
         InetSocketAddress address = new InetSocketAddress("localhost", pickUnusedPort());
 
         // Reflection used since they are only available on linux.
@@ -143,8 +139,7 @@ public void setUp() throws Exception {
         groupToShutdown = group;
         break;
       }
-      case OKHTTP:
-      {
+      case OKHTTP: {
         int port = pickUnusedPort();
         InetSocketAddress address = new InetSocketAddress("localhost", port);
         serverBuilder = NettyServerBuilder.forAddress(address, serverCreds);

benchmarks/src/test/java/io/grpc/benchmarks/driver/LoadWorkerTest.java

@@ -36,7 +36,7 @@
 import org.junit.runners.JUnit4;
 
 /**
- * Basic tests for {@link io.grpc.benchmarks.driver.LoadWorker}
+ * Basic tests for {@link io.grpc.benchmarks.driver.LoadWorker}.
  */
 @RunWith(JUnit4.class)
 public class LoadWorkerTest {