netty: use memory efficient slice in Buffer

carl-mastrangelo · web-flow · commit 8702185e8c9d · 2016-10-20T13:29:36.000-07:00
diff --git a/netty/src/main/java/io/grpc/netty/NettyReadableBuffer.java b/netty/src/main/java/io/grpc/netty/NettyReadableBuffer.java
@@ -93,8 +93,7 @@ public void readBytes(OutputStream dest, int length) {
 
   @Override
   public NettyReadableBuffer readBytes(int length) {
-    // The ByteBuf returned by readSlice() stores a reference to buffer but does not call retain().
-    return new NettyReadableBuffer(buffer.readSlice(length).retain());
+    return new NettyReadableBuffer(buffer.readRetainedSlice(length));
   }
 
   @Override

Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,7 @@ public void readBytes(OutputStream dest, int length) {`
`93`	`93`
`94`	`94`	`@Override`
`95`	`95`	`public NettyReadableBuffer readBytes(int length) {`
`96`		`- // The ByteBuf returned by readSlice() stores a reference to buffer but does not call retain().`
`97`		`- return new NettyReadableBuffer(buffer.readSlice(length).retain());`
	`96`	`+ return new NettyReadableBuffer(buffer.readRetainedSlice(length));`
`98`	`97`	`}`
`99`	`98`
`100`	`99`	`@Override`