Commit 1623063
committed
core: speed up Status code and message parsing
This introduces the idea of a "Trusted" Ascii Marshaller, which is
known to always produce valid ASCII byte arrays. This saves a
surprising amount of garbage, since String conversion involves
creating a new java.lang.StringCoding, and a sun.nio.cs.US_ASCII.
There are other types that can be converted (notably
Http2ClientStream's :status marshaller, which is particularly
wasteful).
Before:
Benchmark Mode Cnt Score Error Units
StatusBenchmark.codeDecode sample 641278 88.889 ± 9.673 ns/op
StatusBenchmark.codeEncode sample 430800 73.014 ± 1.444 ns/op
StatusBenchmark.messageDecodeEscape sample 433467 441.078 ± 58.373 ns/op
StatusBenchmark.messageDecodePlain sample 676526 268.620 ± 7.849 ns/op
StatusBenchmark.messageEncodeEscape sample 547350 1211.243 ± 29.907 ns/op
StatusBenchmark.messageEncodePlain sample 419318 223.263 ± 9.673 ns/op
After:
Benchmark Mode Cnt Score Error Units
StatusBenchmark.codeDecode sample 442241 48.310 ± 2.409 ns/op
StatusBenchmark.codeEncode sample 622026 35.475 ± 0.642 ns/op
StatusBenchmark.messageDecodeEscape sample 595572 312.407 ± 15.870 ns/op
StatusBenchmark.messageDecodePlain sample 565581 99.090 ± 8.799 ns/op
StatusBenchmark.messageEncodeEscape sample 479147 201.422 ± 10.765 ns/op
StatusBenchmark.messageEncodePlain sample 560957 94.722 ± 1.187 ns/op
Also fixes #2237
Before:
Result "unaryCall1024":
mean = 155710.268 ±(99.9%) 149.278 ns/op
Percentiles, ns/op:
p(0.0000) = 63552.000 ns/op
p(50.0000) = 151552.000 ns/op
p(90.0000) = 188672.000 ns/op
p(95.0000) = 207360.000 ns/op
p(99.0000) = 260608.000 ns/op
p(99.9000) = 358912.000 ns/op
p(99.9900) = 1851425.792 ns/op
p(99.9990) = 11161178.767 ns/op
p(99.9999) = 14985005.383 ns/op
p(100.0000) = 17235968.000 ns/op
Benchmark (direct) (transport) Mode Cnt Score Error Units
TransportBenchmark.unaryCall1024 true NETTY sample 3205966 155710.268 ± 149.278 ns/op
After:
Result "unaryCall1024":
mean = 147474.794 ±(99.9%) 128.733 ns/op
Percentiles, ns/op:
p(0.0000) = 59520.000 ns/op
p(50.0000) = 144640.000 ns/op
p(90.0000) = 176128.000 ns/op
p(95.0000) = 190464.000 ns/op
p(99.0000) = 236544.000 ns/op
p(99.9000) = 314880.000 ns/op
p(99.9900) = 1113084.723 ns/op
p(99.9990) = 10783126.979 ns/op
p(99.9999) = 13887153.242 ns/op
p(100.0000) = 15253504.000 ns/op
Benchmark (direct) (transport) Mode Cnt Score Error Units
TransportBenchmark.unaryCall1024 true NETTY sample 3385015 147474.794 ± 128.733 ns/op1 parent af24343 commit 1623063
File tree
5 files changed
+371
-59
lines changed- benchmarks/src/jmh/java/io/grpc
- core/src/main/java/io/grpc
- internal
5 files changed
+371
-59
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
| |||
460 | 462 | | |
461 | 463 | | |
462 | 464 | | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
463 | 469 | | |
464 | 470 | | |
465 | 471 | | |
| |||
603 | 609 | | |
604 | 610 | | |
605 | 611 | | |
606 | | - | |
| 612 | + | |
607 | 613 | | |
608 | 614 | | |
609 | 615 | | |
| |||
619 | 625 | | |
620 | 626 | | |
621 | 627 | | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
622 | 654 | | |
623 | 655 | | |
624 | 656 | | |
| |||
0 commit comments