ESLint: Enable 'dot-notation' rule (#2576)

Author: IvanGoncharov

.eslintrc.yml

@@ -247,7 +247,7 @@ rules:
   default-case: off
   default-case-last: error
   default-param-last: error
-  dot-notation: off
+  dot-notation: error
   eqeqeq: [error, smart]
   grouped-accessor-pairs: error
   guard-for-in: error
@@ -583,6 +583,7 @@ overrides:
 
       # Disable conflicting ESLint rules and enable TS-compatible ones
       default-param-last: off
+      dot-notation: off
       lines-between-class-members: off
       no-array-constructor: off
       no-dupe-class-members: off
@@ -594,6 +595,7 @@ overrides:
       require-await: off
       no-return-await: off
       '@typescript-eslint/default-param-last': error
+      '@typescript-eslint/dot-notation': error
       '@typescript-eslint/lines-between-class-members':
         [error, always, { exceptAfterSingleLine: true }]
       '@typescript-eslint/no-array-constructor': error
@@ -608,7 +610,6 @@ overrides:
       '@typescript-eslint/return-await': error
 
       # Disable for JS, Flow and TS
-      '@typescript-eslint/dot-notation': off # TODO consider
       '@typescript-eslint/init-declarations': off
       '@typescript-eslint/no-magic-numbers': off
       '@typescript-eslint/no-use-before-define': off

resources/gen-changelog.js

@@ -37,7 +37,7 @@ const labelsConfig = {
     fold: true,
   },
 };
-const GH_TOKEN = process.env['GH_TOKEN'];
+const { GH_TOKEN } = process.env;
 
 if (!GH_TOKEN) {
   console.error('Must provide GH_TOKEN as environment variable!');

src/jsutils/__tests__/inspect-test.js

@@ -81,8 +81,8 @@ describe('inspect', () => {
     expect(inspect({ a: { b: { c: 1 } } })).to.equal('{ a: { b: [Object] } }');
 
     const map = Object.create(null);
-    map['a'] = true;
-    map['b'] = null;
+    map.a = true;
+    map.b = null;
     expect(inspect(map)).to.equal('{ a: true, b: null }');
   });