Rename the val parameter to gramps_id for consistency

Author: stevenyoungs

gramps/gen/proxy/living.py

@@ -146,12 +146,12 @@ def iter_people(self):
             else:
                 yield person
 
-    def get_person_from_gramps_id(self, val):
+    def get_person_from_gramps_id(self, gramps_id):
         """
         Finds a Person in the database from the passed Gramps ID.
         If no such Person exists, None is returned.
         """
-        person = self.db.get_person_from_gramps_id(val)
+        person = self.db.get_person_from_gramps_id(gramps_id)
         if person and self.__is_living(person):
             if self.mode == self.MODE_EXCLUDE_ALL:
                 return None
@@ -160,12 +160,12 @@ def get_person_from_gramps_id(self, val):
         else:
             return person
 
-    def get_family_from_gramps_id(self, val):
+    def get_family_from_gramps_id(self, gramps_id):
         """
         Finds a Family in the database from the passed Gramps ID.
         If no such Family exists, None is returned.
         """
-        family = self.db.get_family_from_gramps_id(val)
+        family = self.db.get_family_from_gramps_id(gramps_id)
         family = self.__remove_living_from_family(family)
         return family
 

gramps/gen/proxy/private.py

@@ -168,92 +168,92 @@ def get_note_from_handle(self, handle):
             return note
         return None
 
-    def get_person_from_gramps_id(self, val):
+    def get_person_from_gramps_id(self, gramps_id):
         """
         Finds a Person in the database from the passed Gramps ID.
         If no such Person exists, None is returned.
         """
-        person = self.db.get_person_from_gramps_id(val)
+        person = self.db.get_person_from_gramps_id(gramps_id)
         if person and not person.get_privacy():
             return sanitize_person(self.db, person)
         return None
 
-    def get_family_from_gramps_id(self, val):
+    def get_family_from_gramps_id(self, gramps_id):
         """
         Finds a Family in the database from the passed Gramps ID.
         If no such Family exists, None is returned.
         """
-        family = self.db.get_family_from_gramps_id(val)
+        family = self.db.get_family_from_gramps_id(gramps_id)
         if family and not family.get_privacy():
             return sanitize_family(self.db, family)
         return None
 
-    def get_event_from_gramps_id(self, val):
+    def get_event_from_gramps_id(self, gramps_id):
         """
         Finds an Event in the database from the passed Gramps ID.
         If no such Event exists, None is returned.
         """
-        event = self.db.get_event_from_gramps_id(val)
+        event = self.db.get_event_from_gramps_id(gramps_id)
         if event and not event.get_privacy():
             return sanitize_event(self.db, event)
         return None
 
-    def get_place_from_gramps_id(self, val):
+    def get_place_from_gramps_id(self, gramps_id):
         """
         Finds a Place in the database from the passed Gramps ID.
         If no such Place exists, None is returned.
         """
-        place = self.db.get_place_from_gramps_id(val)
+        place = self.db.get_place_from_gramps_id(gramps_id)
         if place and not place.get_privacy():
             return sanitize_place(self.db, place)
         return None
 
-    def get_source_from_gramps_id(self, val):
+    def get_source_from_gramps_id(self, gramps_id):
         """
         Finds a Source in the database from the passed Gramps ID.
         If no such Source exists, None is returned.
         """
-        source = self.db.get_source_from_gramps_id(val)
+        source = self.db.get_source_from_gramps_id(gramps_id)
         if source and not source.get_privacy():
             return sanitize_source(self.db, source)
         return None
 
-    def get_citation_from_gramps_id(self, val):
+    def get_citation_from_gramps_id(self, gramps_id):
         """
         Finds a Citation in the database from the passed Gramps ID.
         If no such Citation exists, None is returned.
         """
-        citation = self.db.get_citation_from_gramps_id(val)
+        citation = self.db.get_citation_from_gramps_id(gramps_id)
         if citation and not citation.get_privacy():
             return sanitize_citation(self.db, citation)
         return None
 
-    def get_media_from_gramps_id(self, val):
+    def get_media_from_gramps_id(self, gramps_id):
         """
         Finds a Media in the database from the passed Gramps ID.
         If no such Media exists, None is returned.
         """
-        obj = self.db.get_media_from_gramps_id(val)
+        obj = self.db.get_media_from_gramps_id(gramps_id)
         if obj and not obj.get_privacy():
             return sanitize_media(self.db, obj)
         return None
 
-    def get_repository_from_gramps_id(self, val):
+    def get_repository_from_gramps_id(self, gramps_id):
         """
         Finds a Repository in the database from the passed Gramps ID.
         If no such Repository exists, None is returned.
         """
-        repository = self.db.get_repository_from_gramps_id(val)
+        repository = self.db.get_repository_from_gramps_id(gramps_id)
         if repository and not repository.get_privacy():
             return sanitize_repository(self.db, repository)
         return None
 
-    def get_note_from_gramps_id(self, val):
+    def get_note_from_gramps_id(self, gramps_id):
         """
         Finds a Note in the database from the passed Gramps ID.
         If no such Note exists, None is returned.
         """
-        note = self.db.get_note_from_gramps_id(val)
+        note = self.db.get_note_from_gramps_id(gramps_id)
         if note and not note.get_privacy():
             return note
         return None

gramps/gen/proxy/proxybase.py

@@ -567,72 +567,86 @@ def get_tag_from_handle(self, handle):
         """
         return self.gfilter(self.include_tag, self.db.get_tag_from_handle(handle))
 
-    def get_person_from_gramps_id(self, val):
+    def get_person_from_gramps_id(self, gramps_id):
         """
         Finds a Person in the database from the passed Gramps ID.
         If no such Person exists, None is returned.
         """
-        return self.gfilter(self.include_person, self.db.get_person_from_gramps_id(val))
+        return self.gfilter(
+            self.include_person, self.db.get_person_from_gramps_id(gramps_id)
+        )
 
-    def get_family_from_gramps_id(self, val):
+    def get_family_from_gramps_id(self, gramps_id):
         """
         Finds a Family in the database from the passed Gramps ID.
         If no such Family exists, None is returned.
         """
-        return self.gfilter(self.include_family, self.db.get_family_from_gramps_id(val))
+        return self.gfilter(
+            self.include_family, self.db.get_family_from_gramps_id(gramps_id)
+        )
 
-    def get_event_from_gramps_id(self, val):
+    def get_event_from_gramps_id(self, gramps_id):
         """
         Finds an Event in the database from the passed Gramps ID.
         If no such Event exists, None is returned.
         """
-        return self.gfilter(self.include_event, self.db.get_event_from_gramps_id(val))
+        return self.gfilter(
+            self.include_event, self.db.get_event_from_gramps_id(gramps_id)
+        )
 
-    def get_place_from_gramps_id(self, val):
+    def get_place_from_gramps_id(self, gramps_id):
         """
         Finds a Place in the database from the passed gramps' ID.
         If no such Place exists, None is returned.
         """
-        return self.gfilter(self.include_place, self.db.get_place_from_gramps_id(val))
+        return self.gfilter(
+            self.include_place, self.db.get_place_from_gramps_id(gramps_id)
+        )
 
-    def get_source_from_gramps_id(self, val):
+    def get_source_from_gramps_id(self, gramps_id):
         """
         Finds a Source in the database from the passed gramps' ID.
         If no such Source exists, None is returned.
         """
-        return self.gfilter(self.include_source, self.db.get_source_from_gramps_id(val))
+        return self.gfilter(
+            self.include_source, self.db.get_source_from_gramps_id(gramps_id)
+        )
 
-    def get_citation_from_gramps_id(self, val):
+    def get_citation_from_gramps_id(self, gramps_id):
         """
         Finds a Citation in the database from the passed gramps' ID.
         If no such Citation exists, None is returned.
         """
         return self.gfilter(
-            self.include_citation, self.db.get_citation_from_gramps_id(val)
+            self.include_citation, self.db.get_citation_from_gramps_id(gramps_id)
         )
 
-    def get_media_from_gramps_id(self, val):
+    def get_media_from_gramps_id(self, gramps_id):
         """
         Finds a Media in the database from the passed gramps' ID.
         If no such Media exists, None is returned.
         """
-        return self.gfilter(self.include_media, self.db.get_media_from_gramps_id(val))
+        return self.gfilter(
+            self.include_media, self.db.get_media_from_gramps_id(gramps_id)
+        )
 
-    def get_repository_from_gramps_id(self, val):
+    def get_repository_from_gramps_id(self, gramps_id):
         """
         Finds a Repository in the database from the passed gramps' ID.
         If no such Repository exists, None is returned.
         """
         return self.gfilter(
-            self.include_repository, self.db.get_repository_from_gramps_id(val)
+            self.include_repository, self.db.get_repository_from_gramps_id(gramps_id)
         )
 
-    def get_note_from_gramps_id(self, val):
+    def get_note_from_gramps_id(self, gramps_id):
         """
         Finds a Note in the database from the passed gramps' ID.
         If no such Note exists, None is returned.
         """
-        return self.gfilter(self.include_note, self.db.get_note_from_gramps_id(val))
+        return self.gfilter(
+            self.include_note, self.db.get_note_from_gramps_id(gramps_id)
+        )
 
     def get_tag_from_name(self, val):
         """