bigslice: ensure non-zero partition size

josh-newman · jcharum · commit ce3baf013bc3 · 2022-06-01T14:26:04.000Z
Summary: This fixes a crash when using a custom chunk size. Test Plan: Ran a bigslice pipeline that used to crash (with chunk size flag set to 1). Reviewers: jcharumilind Reviewed By: jcharumilind Differential Revision: https://phabricator.grailbio.com/D52965 fbshipit-source-id: b32cc5f
diff --git a/exec/bigmachine.go b/exec/bigmachine.go
@@ -926,7 +926,7 @@ func (w *worker) Run(ctx context.Context, req taskRunRequest, reply *taskRunRepl
 		}
 		return nil
 	case task.NumPartition > 1:
-		var psize = *defaultChunksize / 100
+		var psize = (*defaultChunksize + 99) / 100
 		var (
 			partitionv = make([]frame.Frame, task.NumPartition)
 			lens       = make([]int, task.NumPartition)

Original file line number	Diff line number	Diff line change
`@@ -926,7 +926,7 @@ func (w worker) Run(ctx context.Context, req taskRunRequest, reply taskRunRepl`
`926`	`926`	`}`
`927`	`927`	`return nil`
`928`	`928`	`case task.NumPartition > 1:`
`929`		`- var psize = *defaultChunksize / 100`
	`929`	`+ var psize = (*defaultChunksize + 99) / 100`
`930`	`930`	`var (`
`931`	`931`	`partitionv = make([]frame.Frame, task.NumPartition)`
`932`	`932`	`lens = make([]int, task.NumPartition)`