Skip to content

Commit 6a4cbea

Browse files
authored
Merge pull request #116 from grafana/feature/description-cleanup
fix: remove redundant IP address from description
2 parents 6e18fb7 + 757569f commit 6a4cbea

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

dashboard/extension.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func (ext *extension) Description() string {
8686
return ext.name
8787
}
8888

89-
return fmt.Sprintf("%s (%s) %s", ext.name, ext.options.addr(), ext.options.url())
89+
return fmt.Sprintf("%s %s", ext.name, ext.options.url())
9090
}
9191

9292
// SetThresholds saves thresholds provided by k6 runtime.

dashboard/extension_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func TestNewExtension(t *testing.T) {
3535
assert.NoError(t, err)
3636
assert.NotNil(t, ext)
3737

38-
assert.Equal(t, "dashboard (localhost:1) http://localhost:1", ext.Description())
38+
assert.Equal(t, "dashboard http://localhost:1", ext.Description())
3939

4040
params.ConfigArgument = "period=2"
4141

@@ -179,7 +179,7 @@ func TestExtension_random_port(t *testing.T) {
179179

180180
assert.Equal(
181181
t,
182-
fmt.Sprintf("foo (%s) %s", dashboard.options.addr(), dashboard.options.url()),
182+
fmt.Sprintf("foo %s", dashboard.options.url()),
183183
ext.Description(),
184184
)
185185

0 commit comments

Comments
 (0)