Skip to content

Commit d56639f

Browse files
AnomalRoilAnomalRoil
authored
[CLEANUP] Migration of options to more appropriate sections (#2681)
* [CLEANUP] Moving options to the correct config section This adds an easy migration path to our config handling, which should allow us to migrate option names around much more easily in the future. Any system level config or env variables options are not migrated. This also fixes a bug in our test code, where the root mount path was not properly set in our config, because we used "path:" instead of "path=" to set it. Signed-off-by: Yolan Romailler <[email protected]> * [DOCUMENTATION] Document legacy options and their migration path This also makes sure that legacy options aren't used in the code anymore using the docs test and its regexp Signed-off-by: Yolan Romailler <[email protected]> * [n/a] Removing weird spaces from changelog Signed-off-by: Yolan Romailler <[email protected]> * [DOCUMENTATION] Reformatting our Markdown tables properly Signed-off-by: Yolan Romailler <[email protected]> * [TESTING] Patching a timezone bug in tests This is a fun one where if your Timezone isn't UTC and you are past midnight but it's not past midnight UTC, the tests would fail because you're not using the right date to validate it. Signed-off-by: Yolan Romailler <[email protected]> * [n/a] Fix a typo and use the correct Env variables in the doc about the custom Env variables Signed-off-by: Yolan Romailler <[email protected]> * [BREAKING] Custom Env options moved from GOPASS_CONFIG_CONFIG_KEY_i to GOPASS_CONFIG_KEY_i As discussed in #2617, this actually reflects the way GIT_CONFIG works. It also fixes a potential Panic in our codebase when IsSet was called without any Preset config on a non-existing key. Signed-off-by: Yolan Romailler <[email protected]> * [CLEANUP] Patching all of the new linter complaints Signed-off-by: Yolan Romailler <[email protected]> * [CLEANUP] Use Go1.21 everywhere Signed-off-by: Yolan Romailler <[email protected]> * [n/a] Increase our Golangci timeout Signed-off-by: Yolan Romailler <[email protected]> * [n/a] code review comment and extra regression test Signed-off-by: Yolan Romailler <[email protected]> --------- Signed-off-by: Yolan Romailler <[email protected]>
1 parent 788f577 commit d56639f

File tree

178 files changed

+1484
-1244
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

178 files changed

+1484
-1244
lines changed

‎.github/workflows/autorelease.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
name: Set up Go
2626
uses: actions/setup-go@v4
2727
with:
28-
go-version: '1.20'
28+
go-version: '1.21'
2929
- uses: actions/cache@v3
3030
with:
3131
path: ~/go/pkg/mod

‎.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Set up Go
2727
uses: actions/setup-go@v4
2828
with:
29-
go-version: '1.20'
29+
go-version: '1.21'
3030
- uses: actions/cache@v3
3131
with:
3232
path: ~/go/pkg/mod
@@ -75,7 +75,7 @@ jobs:
7575
- name: Set up Go
7676
uses: actions/setup-go@v4
7777
with:
78-
go-version: '1.20'
78+
go-version: '1.21'
7979

8080
- run: git config --global user.name nobody
8181
- run: git config --global user.email [email protected]
@@ -93,7 +93,7 @@ jobs:
9393
- name: Set up Go
9494
uses: actions/setup-go@v4
9595
with:
96-
go-version: '1.20'
96+
go-version: '1.21'
9797

9898
- run: git config --global user.name nobody
9999
- run: git config --global user.email [email protected]

‎.github/workflows/golangci-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Set up Go
2525
uses: actions/setup-go@v4
2626
with:
27-
go-version: '1.20'
27+
go-version: '1.21'
2828
- uses: actions/checkout@v4
2929
- name: golangci-lint
3030
uses: golangci/golangci-lint-action@v3

‎.github/workflows/grype.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Set up Go
2323
uses: actions/setup-go@v4
2424
with:
25-
go-version: '1.20'
25+
go-version: '1.21'
2626
- uses: actions/cache@v3
2727
with:
2828
path: ~/go/pkg/mod

‎.golangci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
run:
22
skip-dirs:
33
- helpers/
4-
go: 1.20
4+
go: 1.21
5+
deadline: 5m
56

67
linters-settings:
78
gocyclo:
@@ -46,6 +47,7 @@ linters:
4647
- govet
4748
- interfacer
4849
- ifshort
50+
- inamedparam
4951
- interfacebloat
5052
- ireturn
5153
- lll

‎CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ through gopass as well.
218218
* [ENHANCEMENT] Hide password on MacOS clipboards (#2065)
219219
* [ENHANCEMENT] Passage compat improvements (#2060, #2060)
220220
* [ENHANCEMENT] gopass git invokes git directly (#2102)
221-
* [ENHANCEMENT] Template support for the create wizard (#2064)
221+
* [ENHANCEMENT] Template support for the create wizard (#2064)
222222
* [ENHANCENMENT] Check for MacOS Keychain storing the GPG (#2144)
223223
* [EXPERIMENTAL] Support the Fossil SCM (#2092, #2022)
224224
* [FEATURE] Add env variables for custom clipboard commands. (#2091, #2042)
@@ -574,13 +574,13 @@ be included in any binary re-distribution of gopass.
574574

575575
## 1.8.4 / 2018-12-26
576576

577-
* [ENHANCEMENT] Evaluate templates when inserting single secrets [#1023]
578-
* [ENHANCEMENT] Add fuzzy search dialog for gopass otp [#1021]
577+
* [ENHANCEMENT] Evaluate templates when inserting single secrets [#1023]
578+
* [ENHANCEMENT] Add fuzzy search dialog for gopass otp [#1021]
579579
* [ENHANCEMENT] Add edit option to search dialog [#1019]
580580
* [ENHANCEMENT] Introduce build tags for experimental features [#1000]
581581
* [BUGFIX] Fix recursive delete [#1024]
582582
* [BUGFIX] Abort tests on critical failures [#997]
583-
* [BUGFIX] Zsh autocompletion [#996]
583+
* [BUGFIX] Zsh autocompletion [#996]
584584

585585
## 1.8.3 / 2018-11-19
586586

‎Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.20-alpine AS build-env
1+
FROM golang:1.21-alpine AS build-env
22

33
ENV CGO_ENABLED 0
44

‎docs/commands/audit.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ $ gopass audit
1010

1111
## Password strength backends
1212

13-
Backend | Description
14-
------- | -----------
15-
[`zxcvbn`](https://github.com/nbutton23/zxcvbn) | [zxcvbn](https://github.com/dropbox/zxcvbn) password strength checker.
16-
[`crunchy`](https://github.com/muesli/crunchy) | Crunchy password strength checker
17-
`name` | Checks if password equals the name of the secret
13+
| Backend | Description |
14+
|-------------------------------------------------|------------------------------------------------------------------------|
15+
| [`zxcvbn`](https://github.com/nbutton23/zxcvbn) | [zxcvbn](https://github.com/dropbox/zxcvbn) password strength checker. |
16+
| [`crunchy`](https://github.com/muesli/crunchy) | Crunchy password strength checker |
17+
| `name` | Checks if password equals the name of the secret |
1818

1919

‎docs/commands/clone.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ $ gopass clone [email protected]/store.git sub/store
1212

1313
## Flags
1414

15-
Flag | Aliases | Description
16-
---- | ------- | -----------
17-
`--path` | | The path to clone the repo to.
18-
`--crypto` | | Override the crypto backend to use if the auto-detection fails.
15+
| Flag | Aliases | Description |
16+
|------------|---------|-----------------------------------------------------------------|
17+
| `--path` | | The path to clone the repo to. |
18+
| `--crypto` | | Override the crypto backend to use if the auto-detection fails. |

‎docs/commands/config.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ Note: To manage mounts use `gopass mounts`.
88

99
```bash
1010
gopass config
11-
gopass config core.autoclip
12-
gopass config core.autoclip false
11+
gopass config generate.autoclip
12+
gopass config generate.autoclip false
1313
```
1414

1515
## Flags
1616

17-
Flag | Description
18-
---- | -----------
19-
`--store` | Only sync a specific sub store
17+
| Flag | Description |
18+
|-----------|--------------------------------|
19+
| `--store` | Only sync a specific sub store |

0 commit comments

Comments
 (0)