Do not ignore symlinks when listing store contents (#2344)

* Do not ignore symlinks when listing store contents

Fixes #2173

RELEASE_NOTES=[BUGFIX] Do not ignore symlinks when listing

Signed-off-by: Dominik Schulz <[email protected]>

* Do not init map with magic constant.

Signed-off-by: Dominik Schulz <[email protected]>

Signed-off-by: Dominik Schulz <[email protected]>

Author: dominikschulz

internal/backend/storage/fs/store.go

@@ -151,11 +151,13 @@ func (s *Store) Exists(ctx context.Context, name string) bool {
 func (s *Store) List(ctx context.Context, prefix string) ([]string, error) {
 	prefix = strings.TrimPrefix(prefix, "/")
 	debug.Log("Listing %s/%s", s.path, prefix)
+
 	files := make([]string, 0, 100)
-	if err := filepath.Walk(s.path, func(path string, info os.FileInfo, err error) error {
+	if err := walkSymlinks(s.path, func(path string, info os.FileInfo, err error) error {
 		if err != nil {
 			return err
 		}
+
 		relPath := strings.TrimPrefix(path, s.path+string(filepath.Separator)) + string(filepath.Separator)
 		if info.IsDir() && strings.HasPrefix(info.Name(), ".") && path != s.path && !strings.HasPrefix(prefix, relPath) && filepath.Base(path) != filepath.Base(prefix) {
 			debug.Log("skipping dot dir (relPath: %s, prefix: %s)", relPath, prefix)
@@ -175,6 +177,7 @@ func (s *Store) List(ctx context.Context, prefix string) ([]string, error) {
 		if !strings.HasPrefix(name, prefix) {
 			return nil
 		}
+
 		files = append(files, name)
 
 		return nil

internal/backend/storage/fs/walk.go

@@ -0,0 +1,59 @@
+package fs
+
+import (
+	"io/fs"
+	"os"
+	"path/filepath"
+
+	"github.com/gopasspw/gopass/pkg/debug"
+)
+
+func walkSymlinks(path string, walkFn filepath.WalkFunc) error {
+	w := &walker{
+		seen: map[string]bool{},
+	}
+
+	return w.walk(path, path, walkFn)
+}
+
+type walker struct {
+	seen map[string]bool
+}
+
+func (w *walker) walk(filename, linkDir string, walkFn filepath.WalkFunc) error {
+	sWalkFn := func(path string, info fs.FileInfo, err error) error {
+		fname, err := filepath.Rel(filename, path)
+		if err != nil {
+			return err
+		}
+		path = filepath.Join(linkDir, fname)
+
+		if info.Mode()&fs.ModeSymlink == fs.ModeSymlink {
+			destPath, err := filepath.EvalSymlinks(path)
+			if err != nil {
+				return err
+			}
+
+			// avoid loops
+			if w.seen[destPath] {
+				debug.Log("Symlink loop detected at %s!", destPath)
+
+				return nil
+			}
+			w.seen[destPath] = true
+
+			destInfo, err := os.Lstat(destPath)
+			if err != nil {
+				return walkFn(path, destInfo, err)
+			}
+
+			if destInfo.IsDir() {
+				return w.walk(destPath, path, walkFn)
+			}
+		}
+
+		return walkFn(path, info, err)
+	}
+
+	return filepath.Walk(filename, sWalkFn)
+}