Skip to content

Commit 42ec61c

Browse files
committed
[n/a] code review comment and extra regression test
1 parent 29054e9 commit 42ec61c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

internal/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ func (c *Config) migrateOptions(migrations map[string]string) {
300300
}
301301
}
302302
}
303-
if err := errors.Join(errors.Join(errs...)); err != nil {
303+
if err := errors.Join(errs...); err != nil {
304304
debug.Log("Errors encountered while migrating old options: {%v}", err)
305305
}
306306
}

pkg/gitconfig/configs_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ func TestConfigs(t *testing.T) {
9696
require.Error(t, c.SetLocal("core.foo", "bar"))
9797
require.NoError(t, c.SetGlobal("core.global", "foo"))
9898
require.NoError(t, c.SetEnv("env.var", "var"))
99+
require.False(t, c.IsSet("env.nonexistent"))
99100
}

0 commit comments

Comments
 (0)