Skip to content

Commit 80fb4e3

Browse files
wanlin31copybara-github
authored andcommitted
feat: allow methods in batch to return headers in sdk_http_response by default
PiperOrigin-RevId: 789392436
1 parent 608d48a commit 80fb4e3

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

google/genai/batches.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1648,6 +1648,11 @@ def _DeleteResourceJob_from_mldev(
16481648
parent_object: Optional[dict[str, Any]] = None,
16491649
) -> dict[str, Any]:
16501650
to_object: dict[str, Any] = {}
1651+
if getv(from_object, ['sdkHttpResponse']) is not None:
1652+
setv(
1653+
to_object, ['sdk_http_response'], getv(from_object, ['sdkHttpResponse'])
1654+
)
1655+
16511656
if getv(from_object, ['name']) is not None:
16521657
setv(to_object, ['name'], getv(from_object, ['name']))
16531658

@@ -1815,6 +1820,11 @@ def _DeleteResourceJob_from_vertex(
18151820
parent_object: Optional[dict[str, Any]] = None,
18161821
) -> dict[str, Any]:
18171822
to_object: dict[str, Any] = {}
1823+
if getv(from_object, ['sdkHttpResponse']) is not None:
1824+
setv(
1825+
to_object, ['sdk_http_response'], getv(from_object, ['sdkHttpResponse'])
1826+
)
1827+
18181828
if getv(from_object, ['name']) is not None:
18191829
setv(to_object, ['name'], getv(from_object, ['name']))
18201830

@@ -2186,7 +2196,9 @@ def delete(
21862196
return_value = types.DeleteResourceJob._from_response(
21872197
response=response_dict, kwargs=parameter_model.model_dump()
21882198
)
2189-
2199+
return_value.sdk_http_response = types.HttpResponse(
2200+
headers=response.headers
2201+
)
21902202
self._api_client._verify_response(return_value)
21912203
return return_value
21922204

@@ -2619,7 +2631,9 @@ async def delete(
26192631
return_value = types.DeleteResourceJob._from_response(
26202632
response=response_dict, kwargs=parameter_model.model_dump()
26212633
)
2622-
2634+
return_value.sdk_http_response = types.HttpResponse(
2635+
headers=response.headers
2636+
)
26232637
self._api_client._verify_response(return_value)
26242638
return return_value
26252639

google/genai/types.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10771,6 +10771,9 @@ class _DeleteBatchJobParametersDict(TypedDict, total=False):
1077110771
class DeleteResourceJob(_common.BaseModel):
1077210772
"""The return value of delete operation."""
1077310773

10774+
sdk_http_response: Optional[HttpResponse] = Field(
10775+
default=None, description="""Used to retain the full HTTP response."""
10776+
)
1077410777
name: Optional[str] = Field(default=None, description="""""")
1077510778
done: Optional[bool] = Field(default=None, description="""""")
1077610779
error: Optional[JobError] = Field(default=None, description="""""")
@@ -10779,6 +10782,9 @@ class DeleteResourceJob(_common.BaseModel):
1077910782
class DeleteResourceJobDict(TypedDict, total=False):
1078010783
"""The return value of delete operation."""
1078110784

10785+
sdk_http_response: Optional[HttpResponseDict]
10786+
"""Used to retain the full HTTP response."""
10787+
1078210788
name: Optional[str]
1078310789
""""""
1078410790

0 commit comments

Comments
 (0)