fixed test issues

Author: daniel-sanche

google/cloud/firestore_v1/async_pipeline.py

@@ -17,7 +17,7 @@
 from google.cloud.firestore_v1 import pipeline_stages as stages
 from google.cloud.firestore_v1.base_pipeline import _BasePipeline
 
-if TYPE_CHECKING:
+if TYPE_CHECKING:  # pragma: NO COVER
     from google.cloud.firestore_v1.async_client import AsyncClient
     from google.cloud.firestore_v1.pipeline_result import PipelineResult
     from google.cloud.firestore_v1.async_transaction import AsyncTransaction

google/cloud/firestore_v1/base_pipeline.py

@@ -22,7 +22,7 @@
 from google.cloud.firestore_v1.pipeline_result import PipelineResult
 from google.cloud.firestore_v1 import _helpers
 
-if TYPE_CHECKING:
+if TYPE_CHECKING:  # pragma: NO COVER
     from google.cloud.firestore_v1.client import Client
     from google.cloud.firestore_v1.async_client import AsyncClient
     from google.cloud.firestore_v1.types.firestore import ExecutePipelineResponse

google/cloud/firestore_v1/pipeline.py

@@ -17,7 +17,7 @@
 from google.cloud.firestore_v1 import pipeline_stages as stages
 from google.cloud.firestore_v1.base_pipeline import _BasePipeline
 
-if TYPE_CHECKING:
+if TYPE_CHECKING:  # pragma: NO COVER
     from google.cloud.firestore_v1.client import Client
     from google.cloud.firestore_v1.pipeline_result import PipelineResult
     from google.cloud.firestore_v1.transaction import Transaction

google/cloud/firestore_v1/pipeline_expressions.py

@@ -66,10 +66,6 @@ def __repr__(self):
     def _to_pb(self) -> Value:
         raise NotImplementedError
 
-    @staticmethod
-    def _cast_to_expr_or_convert_to_constant(o: Any) -> "Expr":
-        return o if isinstance(o, Expr) else Constant(o)
-
 
 class Constant(Expr, Generic[CONSTANT_TYPE]):
     """Represents a constant literal value in an expression."""

google/cloud/firestore_v1/pipeline_result.py

@@ -18,7 +18,7 @@
 from google.cloud.firestore_v1.field_path import get_nested_value
 from google.cloud.firestore_v1.field_path import FieldPath
 
-if TYPE_CHECKING:
+if TYPE_CHECKING:  # pragma: NO COVER
     from google.cloud.firestore_v1.base_client import BaseClient
     from google.cloud.firestore_v1.base_document import BaseDocumentReference
     from google.protobuf.timestamp_pb2 import Timestamp

google/cloud/firestore_v1/pipeline_source.py

@@ -17,7 +17,7 @@
 from google.cloud.firestore_v1 import pipeline_stages as stages
 from google.cloud.firestore_v1.base_pipeline import _BasePipeline
 
-if TYPE_CHECKING:
+if TYPE_CHECKING:  # pragma: NO COVER
     from google.cloud.firestore_v1.client import Client
     from google.cloud.firestore_v1.async_client import AsyncClient
 

tests/unit/v1/test_async_client.py

@@ -533,11 +533,11 @@ def test_asyncclient_transaction():
     assert transaction._id is None
 
 
-def test_asyncclient_pipeline(database):
+def test_asyncclient_pipeline():
     from google.cloud.firestore_v1.async_pipeline import AsyncPipeline
     from google.cloud.firestore_v1.pipeline_source import PipelineSource
 
-    client = _make_default_async_client(database=database)
+    client = _make_default_async_client()
     ppl = client.pipeline()
     assert client._pipeline_cls == AsyncPipeline
     assert isinstance(ppl, PipelineSource)

tests/unit/v1/test_pipeline_result.py

@@ -86,6 +86,11 @@ def test_eq(self, first, second, result):
         second_obj = self._make_one(*second)
         assert (first_obj == second_obj) is result
 
+    def test_eq_wrong_type(self):
+        instance = self._make_one()
+        result = instance == object()
+        assert result is False
+
     def test_data(self):
         from google.cloud.firestore_v1.types.document import Value