Skip to content

Commit 72b69fc

Browse files
authored
fix: stabilize the order of resource helper methods and (#582)
1 parent 91ff85f commit 72b69fc

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/gapic-generator/gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ def test_{{ service.name|snake_case }}_grpc_lro_client():
748748

749749
{% endif -%}
750750

751-
{% for message in service.resource_messages -%}
751+
{% for message in service.resource_messages|sort(attribute="resource_type") -%}
752752
{% with molluscs = cycler("squid", "clam", "whelk", "octopus", "oyster", "nudibranch", "cuttlefish", "mussel", "winkle", "nautilus", "scallop", "abalone") -%}
753753
def test_{{ message.resource_type|snake_case }}_path():
754754
{% for arg in message.resource_path_args -%}

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ class {{ service.async_client_name }}:
3838
DEFAULT_ENDPOINT = {{ service.client_name }}.DEFAULT_ENDPOINT
3939
DEFAULT_MTLS_ENDPOINT = {{ service.client_name }}.DEFAULT_MTLS_ENDPOINT
4040

41-
{% for message in service.resource_messages -%}
41+
{% for message in service.resource_messages|sort(attribute="resource_type") -%}
4242
{{ message.resource_type|snake_case }}_path = staticmethod({{ service.client_name }}.{{ message.resource_type|snake_case }}_path)
43-
43+
parse_{{ message.resource_type|snake_case}}_path = staticmethod({{ service.client_name }}.parse_{{ message.resource_type|snake_case }}_path)
4444
{% endfor %}
4545

4646
from_service_account_file = {{ service.client_name }}.from_service_account_file

packages/gapic-generator/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1343,7 +1343,7 @@ def test_{{ service.name|snake_case }}_grpc_lro_async_client():
13431343

13441344
{% endif -%}
13451345

1346-
{% for message in service.resource_messages -%}
1346+
{% for message in service.resource_messages|sort(attribute="resource_type") -%}
13471347
{% with molluscs = cycler("squid", "clam", "whelk", "octopus", "oyster", "nudibranch", "cuttlefish", "mussel", "winkle", "nautilus", "scallop", "abalone") -%}
13481348
def test_{{ message.resource_type|snake_case }}_path():
13491349
{% for arg in message.resource_path_args -%}

0 commit comments

Comments
 (0)