pep8 fixes, and tests changes, adding attribute _path

Author: philquinn

gcloud/pubsub/subscription.py

@@ -45,6 +45,7 @@ def __init__(self, name, topic, ack_deadline=None, push_endpoint=None):
         self.topic = topic
         self.ack_deadline = ack_deadline
         self.push_endpoint = push_endpoint
+        self._path = None
 
     @classmethod
     def from_api_repr(cls, resource, topics=None):
@@ -76,17 +77,15 @@ def path(self):
         """URL path for the subscription's APIs"""
         project = self.topic.project
         path = '/projects/%s/subscriptions/%s' % (project, self.name)
-        if hasattr(self,"_path"):
-            path = '/projects/%s/subscriptions/%s' % (project, self.name)
+        if self._path is not None:
+            path = self._path
         return path
 
-
     @path.setter
     def path(self, project):
         """URL path setter"""
         self._path = '/projects/%s/subscriptions/%s' % (project, self.name)
 
-
     def create(self, connection=None):
         """API call:  create the subscription via a PUT request
 

gcloud/pubsub/test_subscription.py

@@ -458,17 +458,16 @@ def test_delete_w_explicit_connection(self):
 
     def test_set_path_property(self):
         PROJECT = 'PROJECT'
-        NEW_PROJECT = 'NEW_PROJECT'
+        PROJECT2 = 'PROJECT2'
         SUB_NAME = 'sub_name'
         SUB_PATH = '/projects/%s/subscriptions/%s' % (PROJECT, SUB_NAME)
-        NEW_SUB_PATH = '/projects/%s/subscriptions/%s' % (NEW_PROJECT, SUB_NAME)
+        SUB_PATH2 = '/projects/%s/subscriptions/%s' % (PROJECT2, SUB_NAME)
         TOPIC_NAME = 'topic_name'
-        conn = _Connection({})
         topic = _Topic(TOPIC_NAME, project=PROJECT)
         subscription = self._makeOne(SUB_NAME, topic)
-        self.assertEqual(SUB_PATH ,subscription.path)
-        subscription.path = NEW_PROJECT
-        self.assertEqual(NEW_SUB_PATH, subscription.path)
+        self.assertEqual(SUB_PATH, subscription.path)
+        subscription.path = PROJECT2
+        self.assertEqual(SUB_PATH2, subscription.path)
 
 
 class _Connection(object):