Skip to content

Commit 33d0ea7

Browse files
author
Luke Sneeringer
committed
Update library to use admin_database autogen.
* Remove dependency on gapic-google-cloud-spanner-admin-database-v1 * Update imports
1 parent 50aea4a commit 33d0ea7

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

spanner/google/cloud/spanner/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from google.api.core import page_iterator
2828
from google.gax import INITIAL_PAGE
2929
# pylint: disable=line-too-long
30-
from google.cloud.gapic.spanner_admin_database.v1.database_admin_client import ( # noqa
30+
from google.cloud.spanner_admin_database_v1.gapic.database_admin_client import ( # noqa
3131
DatabaseAdminClient)
3232
from google.cloud.gapic.spanner_admin_instance.v1.instance_admin_client import ( # noqa
3333
InstanceAdminClient)

spanner/setup.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,14 @@
5151

5252

5353
REQUIREMENTS = [
54-
'google-cloud-core >= 0.27.0, < 0.28dev',
55-
'google-auth >= 1.1.0',
56-
'grpcio >= 1.2.0, < 2.0dev',
5754
'gapic-google-cloud-spanner-v1 >= 0.15.0, < 0.16dev',
58-
'gapic-google-cloud-spanner-admin-database-v1 >= 0.15.0, < 0.16dev',
5955
'gapic-google-cloud-spanner-admin-instance-v1 >= 0.15.0, < 0.16dev',
56+
'google-auth >= 1.1.0',
57+
'google-cloud-core >= 0.27.0, < 0.28dev',
58+
'google-gax>=0.15.15, <0.16dev',
59+
'googleapis-common-protos[grpc]>=1.5.2, <2.0dev',
60+
'grpc-google-iam-v1>=0.11.4, <0.12dev',
61+
'requests>=2.18.4, <3.0dev',
6062
]
6163

6264
setup(

spanner/tests/unit/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def test_constructor_credentials_wo_create_scoped(self):
107107

108108
def test_admin_api_lib_name(self):
109109
from google.cloud.spanner import __version__
110-
from google.cloud.gapic.spanner_admin_database import v1 as db
110+
from google.cloud.spanner_admin_database_v1 import gapic as db
111111
from google.cloud.gapic.spanner_admin_instance import v1 as inst
112112

113113
# Get the actual admin client classes.

spanner/tests/unit/test_database.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def test_ctor_w_ddl_statements_ok(self):
106106
self.assertEqual(list(database.ddl_statements), DDL_STATEMENTS)
107107

108108
def test_from_pb_bad_database_name(self):
109-
from google.cloud.proto.spanner.admin.database.v1 import (
109+
from google.cloud.spanner_admin_database_v1.proto import (
110110
spanner_database_admin_pb2 as admin_v1_pb2)
111111

112112
database_name = 'INCORRECT_FORMAT'
@@ -117,7 +117,7 @@ def test_from_pb_bad_database_name(self):
117117
klass.from_pb(database_pb, None)
118118

119119
def test_from_pb_project_mistmatch(self):
120-
from google.cloud.proto.spanner.admin.database.v1 import (
120+
from google.cloud.spanner_admin_database_v1.proto import (
121121
spanner_database_admin_pb2 as admin_v1_pb2)
122122

123123
ALT_PROJECT = 'ALT_PROJECT'
@@ -130,7 +130,7 @@ def test_from_pb_project_mistmatch(self):
130130
klass.from_pb(database_pb, instance)
131131

132132
def test_from_pb_instance_mistmatch(self):
133-
from google.cloud.proto.spanner.admin.database.v1 import (
133+
from google.cloud.spanner_admin_database_v1.proto import (
134134
spanner_database_admin_pb2 as admin_v1_pb2)
135135

136136
ALT_INSTANCE = '/projects/%s/instances/ALT-INSTANCE' % (
@@ -144,7 +144,7 @@ def test_from_pb_instance_mistmatch(self):
144144
klass.from_pb(database_pb, instance)
145145

146146
def test_from_pb_success_w_explicit_pool(self):
147-
from google.cloud.proto.spanner.admin.database.v1 import (
147+
from google.cloud.spanner_admin_database_v1.proto import (
148148
spanner_database_admin_pb2 as admin_v1_pb2)
149149

150150
client = _Client()
@@ -161,7 +161,7 @@ def test_from_pb_success_w_explicit_pool(self):
161161
self.assertIs(database._pool, pool)
162162

163163
def test_from_pb_success_w_hyphen_w_default_pool(self):
164-
from google.cloud.proto.spanner.admin.database.v1 import (
164+
from google.cloud.spanner_admin_database_v1.proto import (
165165
spanner_database_admin_pb2 as admin_v1_pb2)
166166
from google.cloud.spanner.pool import BurstyPool
167167

@@ -411,7 +411,7 @@ def test_exists_not_found(self):
411411
[('google-cloud-resource-prefix', database.name)])
412412

413413
def test_exists_success(self):
414-
from google.cloud.proto.spanner.admin.database.v1 import (
414+
from google.cloud.spanner_admin_database_v1.proto import (
415415
spanner_database_admin_pb2 as admin_v1_pb2)
416416
from tests._fixtures import DDL_STATEMENTS
417417

@@ -468,7 +468,7 @@ def test_reload_not_found(self):
468468
[('google-cloud-resource-prefix', database.name)])
469469

470470
def test_reload_success(self):
471-
from google.cloud.proto.spanner.admin.database.v1 import (
471+
from google.cloud.spanner_admin_database_v1.proto import (
472472
spanner_database_admin_pb2 as admin_v1_pb2)
473473
from tests._fixtures import DDL_STATEMENTS
474474

0 commit comments

Comments
 (0)