Skip to content

Commit 2f3f5dc

Browse files
committed
Overwriting user_agent in storage/datastore connection tests.
This prevents unnecessary HTTP requests to determine if GCE is the current environment.
1 parent 4d9560d commit 2f3f5dc

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

gcloud/datastore/test_connection.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ def _make_query_pb(self, kind):
3636
return pb
3737

3838
def _makeOne(self, *args, **kw):
39-
return self._getTargetClass()(*args, **kw)
39+
conn = self._getTargetClass()(*args, **kw)
40+
# Set the user agent so the user_agent is not lazily loaded.
41+
setattr(conn, 'user_agent', 'gcloud-python/test')
42+
return conn
4043

4144
def _verifyProtobufCall(self, called_with, URI, conn):
4245
self.assertEqual(called_with['uri'], URI)

gcloud/storage/test_connection.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ def _getTargetClass(self):
2222
return Connection
2323

2424
def _makeOne(self, *args, **kw):
25-
return self._getTargetClass()(*args, **kw)
25+
conn = self._getTargetClass()(*args, **kw)
26+
# Set the user agent so the user_agent is not lazily loaded.
27+
setattr(conn, 'user_agent', 'gcloud-python/test')
28+
return conn
2629

2730
def test_ctor_defaults(self):
2831
PROJECT = 'project'

0 commit comments

Comments
 (0)