Skip to content

Commit 2831d5c

Browse files
author
Jon Wayne Parrott
authored
Re-enable lint for tests, remove usage of pylint (#4921)
1 parent 5c84c0d commit 2831d5c

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

packages/google-cloud-monitoring/.flake8

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
[flake8]
22
exclude =
3+
# Exclude generated code.
4+
**/proto/**
5+
**/gapic/**
6+
*_pb2.py
7+
8+
# Standard linting exemptions.
39
__pycache__,
410
.git,
511
*.pyc,

packages/google-cloud-monitoring/nox.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,9 @@ def lint(session):
9999
serious code quality issues.
100100
"""
101101
session.interpreter = 'python3.6'
102-
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
102+
session.install('flake8')
103103
session.install('.')
104-
session.run('flake8', 'google/cloud/monitoring')
105-
session.run(
106-
'gcp-devrel-py-tools', 'run-pylint',
107-
'--config', 'pylint.config.py',
108-
'--library-filesets', 'google',
109-
'--test-filesets', 'tests',
110-
# Temporarily allow this to fail.
111-
success_codes=range(0, 100))
104+
session.run('flake8', 'google', 'tests')
112105

113106

114107
@nox.session

0 commit comments

Comments
 (0)