fix: 'id' should not be a reserved name (#602)

software-dov · web-flow · commit 210cdb3a6fe0 · 2020-09-17T09:06:38.000-07:00
A number of python builtins collide with flattened fields from certain
API methods. More common names, especially ones that conflict with
builtins that aren't used by the surface, are explicitly allowed.
diff --git a/packages/gapic-generator/gapic/utils/reserved_names.py b/packages/gapic-generator/gapic/utils/reserved_names.py
@@ -24,6 +24,6 @@
 RESERVED_NAMES = frozenset(
     itertools.chain(
         keyword.kwlist,
-        set(dir(builtins)) - {"filter", "map"},
+        set(dir(builtins)) - {"filter", "map", "id"},
     )
 )

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,6 @@`
`24`	`24`	`RESERVED_NAMES = frozenset(`
`25`	`25`	`itertools.chain(`
`26`	`26`	`keyword.kwlist,`
`27`		`- set(dir(builtins)) - {"filter", "map"},`
	`27`	`+ set(dir(builtins)) - {"filter", "map", "id"},`
`28`	`28`	`)`
`29`	`29`	`)`