Skip to content

Commit 2995240

Browse files
committed
Fix minor style errros
1 parent 357c779 commit 2995240

File tree

7 files changed

+8
-11
lines changed

7 files changed

+8
-11
lines changed

gcloud-java-core/src/main/java/com/google/cloud/BatchResult.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public abstract class BatchResult<T, E extends BaseServiceException> {
3434
private T result;
3535
private boolean completed = false;
3636
private E error;
37-
private List<Callback<T, E>> toBeNotified = new LinkedList<>();
37+
private final List<Callback<T, E>> toBeNotified = new LinkedList<>();
3838

3939
/**
4040
* Returns {@code true} if the batch has been completed and the result is available; {@code false}

gcloud-java-dns/src/main/java/com/google/cloud/dns/DnsBatch.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
*/
4343
public class DnsBatch {
4444

45-
private RpcBatch batch;
45+
private final RpcBatch batch;
4646
private final DnsRpc dnsRpc;
4747
private final DnsOptions options;
4848

gcloud-java-dns/src/main/java/com/google/cloud/dns/DnsImpl.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ public Page<RecordSet> nextPage() {
113113
static Function<ManagedZone, Zone> zoneFromPb(final DnsOptions options) {
114114
return new Function<ManagedZone, Zone>() {
115115
@Override
116-
public Zone apply(
117-
com.google.api.services.dns.model.ManagedZone zonePb) {
116+
public Zone apply(ManagedZone zonePb) {
118117
return Zone.fromPb(options.service(), zonePb);
119118
}
120119
};

gcloud-java-dns/src/main/java/com/google/cloud/dns/spi/DefaultDnsRpc.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public class DefaultDnsRpc implements DnsRpc {
5858

5959
private class DefaultRpcBatch implements RpcBatch {
6060

61-
private BatchRequest batch;
61+
private final BatchRequest batch;
6262

6363
private DefaultRpcBatch(BatchRequest batch) {
6464
this.batch = batch;

gcloud-java-dns/src/test/java/com/google/cloud/dns/DnsBatchResultTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import static org.junit.Assert.assertTrue;
2222
import static org.junit.Assert.fail;
2323

24-
import com.google.cloud.BaseServiceException;
2524
import com.google.cloud.BatchResult;
2625

2726
import org.easymock.EasyMock;

gcloud-java-dns/src/test/java/com/google/cloud/dns/DnsBatchTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public class DnsBatchTest {
101101
private DnsRpc dnsRpcMock;
102102
private RpcBatch batchMock;
103103
private DnsBatch dnsBatch;
104-
private Dns dns = EasyMock.createStrictMock(Dns.class);
104+
private final Dns dns = EasyMock.createStrictMock(Dns.class);
105105

106106
@Before
107107
public void setUp() {

gcloud-java-dns/src/test/java/com/google/cloud/dns/testing/LocalDnsHelperTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2378,12 +2378,11 @@ public void onSuccess(ChangesListResponse response) {
23782378
}, ImmutableMap.of(DnsRpc.Option.PAGE_SIZE, 2));
23792379
final Iterable<Change> descending = RPC.listChangeRequests(ZONE1.getName(),
23802380
ImmutableMap.of(DnsRpc.Option.SORTING_ORDER, "descending")).results();
2381-
final int size = 4;
23822381
batch.addListChangeRequests(ZONE_NAME1, new SuccessExpectedCallback<ChangesListResponse>() {
23832382
@Override
23842383
public void onSuccess(ChangesListResponse response) {
23852384
List<Change> changes = response.getChanges();
2386-
for (int i = 0; i < size; i++) {
2385+
for (int i = 0; i < 4; i++) {
23872386
assertEquals(Iterables.get(descending, i), changes.get(i));
23882387
}
23892388
}
@@ -2392,8 +2391,8 @@ public void onSuccess(ChangesListResponse response) {
23922391
@Override
23932392
public void onSuccess(ChangesListResponse response) {
23942393
List<Change> changes = response.getChanges();
2395-
for (int i = 0; i < size; i++) {
2396-
assertEquals(Iterables.get(descending, i), changes.get(size - i - 1));
2394+
for (int i = 0; i < 4; i++) {
2395+
assertEquals(Iterables.get(descending, i), changes.get(3 - i));
23972396
}
23982397
}
23992398
}, ImmutableMap.of(DnsRpc.Option.SORTING_ORDER, "ascending"));

0 commit comments

Comments
 (0)