fix(storage): pass all user options to NewService (#12615)

tritone · web-flow · commit 77cdb832a374 · 2025-07-31T22:51:02.000-07:00
diff --git a/storage/storage.go b/storage/storage.go
@@ -208,7 +208,9 @@ func NewClient(ctx context.Context, opts ...option.ClientOption) (*Client, error
 		return nil, fmt.Errorf("dialing: %w", err)
 	}
 	// RawService should be created with the chosen endpoint to take account of user override.
-	rawService, err := raw.NewService(ctx, option.WithEndpoint(ep), option.WithHTTPClient(hc))
+	// Preserve other user-supplied options as well.
+	opts = append(opts, option.WithEndpoint(ep), option.WithHTTPClient(hc))
+	rawService, err := raw.NewService(ctx, opts...)
 	if err != nil {
 		return nil, fmt.Errorf("storage client: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,9 @@ func NewClient(ctx context.Context, opts ...option.ClientOption) (*Client, error`
`208`	`208`	`return nil, fmt.Errorf("dialing: %w", err)`
`209`	`209`	`}`
`210`	`210`	`// RawService should be created with the chosen endpoint to take account of user override.`
`211`		`- rawService, err := raw.NewService(ctx, option.WithEndpoint(ep), option.WithHTTPClient(hc))`
	`211`	`+ // Preserve other user-supplied options as well.`
	`212`	`+ opts = append(opts, option.WithEndpoint(ep), option.WithHTTPClient(hc))`
	`213`	`+ rawService, err := raw.NewService(ctx, opts...)`
`212`	`214`	`if err != nil {`
`213`	`215`	`return nil, fmt.Errorf("storage client: %w", err)`
`214`	`216`	`}`