Skip to content

Commit acf5bb5

Browse files
cpovirkGoogle Java Core Libraries
authored andcommitted
Use Java 25 for Javadoc links, too.
(followup to 5752811) I may have waffled over whether to link to 21 (most recent LTS) or 23 (most recent STS) back in 166bb20. - I can see an argument that 21 is more likely to be what users want, since they're more likely to actually be using it. - But by linking to the newest STS, we can given advice about the newest Java APIs, like the `Reader` APIs in 9a179fc. - And anyway, no matter which version we link to, we're going to pick the "wrong" one for someone. (For all I know, there might be more people on, say, Java 17 than on Java 21.) - Plus, the Javadoc UX has in general improved over the years, so newer is better in that sense. - Finally, there is probably value in matching the Javadoc version that we're using to generate Javadoc with the version that we're linking to: I think that, in the past, we've seen disagreements over whether links end `#foo()` or `#foo--` and maybe occasional other changes in link format. (Another change in link format was b/305225234 / [JDK-8318093](https://bugs.openjdk.org/browse/JDK-8318093). But this may be more likely to be example of an improvement in Javadoc over time than a case in which we'd actually see a broken link from the disagreement.) RELNOTES=n/a PiperOrigin-RevId: 813748397
1 parent 7730d13 commit acf5bb5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

android/guava/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@
191191
</tags>
192192

193193
<!-- TODO(cpovirk): Move this to the parent after making the package-list files available there. -->
194-
<!-- We add the link ourselves so that we can choose Java 21 over the version that -source suggests. -->
194+
<!-- We add the link ourselves so that we can choose Java 25 over the version that -source suggests. -->
195195
<detectJavaApiLink>false</detectJavaApiLink>
196196
<offlineLinks>
197197
<!-- We need local copies of some of these for 2 reasons: a User-Agent problem (https://stackoverflow.com/a/47891403/28465) and an SSL problem (https://issues.apache.org/jira/browse/MJAVADOC-507). If we choose to work around the User-Agent problem, we can go back to <links>, sidestepping the SSL problem. -->
@@ -201,7 +201,7 @@
201201
</offlineLink>
202202
</offlineLinks>
203203
<links>
204-
<link>https://docs.oracle.com/en/java/javase/21/docs/api/</link>
204+
<link>https://docs.oracle.com/en/java/javase/25/docs/api/</link>
205205
<link>https://errorprone.info/api/latest/</link>
206206
<link>https://jspecify.dev/docs/api/</link>
207207
</links>

guava/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@
184184
</tags>
185185

186186
<!-- TODO(cpovirk): Move this to the parent after making the package-list files available there. -->
187-
<!-- We add the link ourselves so that we can choose Java 21 over the version that -source suggests. -->
187+
<!-- We add the link ourselves so that we can choose Java 25 over the version that -source suggests. -->
188188
<detectJavaApiLink>false</detectJavaApiLink>
189189
<offlineLinks>
190190
<!-- We need local copies of some of these for 2 reasons: a User-Agent problem (https://stackoverflow.com/a/47891403/28465) and an SSL problem (https://issues.apache.org/jira/browse/MJAVADOC-507). If we choose to work around the User-Agent problem, we can go back to <links>, sidestepping the SSL problem. -->
@@ -194,7 +194,7 @@
194194
</offlineLink>
195195
</offlineLinks>
196196
<links>
197-
<link>https://docs.oracle.com/en/java/javase/21/docs/api/</link>
197+
<link>https://docs.oracle.com/en/java/javase/25/docs/api/</link>
198198
<link>https://errorprone.info/api/latest/</link>
199199
<link>https://jspecify.dev/docs/api/</link>
200200
</links>

0 commit comments

Comments
 (0)