Skip to content

Commit 895980e

Browse files
committed
use familyname instead of last name
1 parent bf0a905 commit 895980e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

github/scim.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717
// GitHub API docs: https://docs.github.com/en/rest/reference/scim
1818
type SCIMService service
1919

20-
// SCIMUserAttributes represents supported SCIM User atrributes.
20+
// SCIMUserAttributes represents supported SCIM User attributes.
2121
//
2222
// GitHub API docs: https://docs.github.com/en/rest/reference/scim#supported-scim-user-attributes
2323
type SCIMUserAttributes struct {
@@ -33,9 +33,9 @@ type SCIMUserAttributes struct {
3333

3434
// SCIMUserName represents SCIM user information.
3535
type SCIMUserName struct {
36-
GivenName string `json:"givenName"` // The first name of the user. (Required.)
37-
LastName string `json:"lastName"` // The last name of the user. (Required.)
38-
Formatted *string `json:"formatted,omitempty"` // (Optional.)
36+
GivenName string `json:"givenName"` // The first name of the user. (Required.)
37+
FamilyName string `json:"familyName"` // The family name of the user. (Required.)
38+
Formatted *string `json:"formatted,omitempty"` // (Optional.)
3939
}
4040

4141
//SCIMUserEmail represents SCIM user email.

github/scim_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ func TestSCIMService_ProvisionAndInviteSCIMUser(t *testing.T) {
5151
opts := &SCIMUserAttributes{
5252
UserName: "userName",
5353
Name: SCIMUserName{
54-
GivenName: "givenName",
55-
LastName: "lastName",
54+
GivenName: "givenName",
55+
FamilyName: "familyName",
5656
},
5757
Emails: []*SCIMUserEmail{
5858
{
@@ -115,8 +115,8 @@ func TestSCIMService_UpdateProvisionedOrgMembership(t *testing.T) {
115115
opts := &SCIMUserAttributes{
116116
UserName: "userName",
117117
Name: SCIMUserName{
118-
GivenName: "givenName",
119-
LastName: "lastName",
118+
GivenName: "givenName",
119+
FamilyName: "familyName",
120120
},
121121
Emails: []*SCIMUserEmail{
122122
{

0 commit comments

Comments
 (0)