Add a "alias_string_mode" ALL_AGGRESSIVE.

PiperOrigin-RevId: 701985985

Author: concavelenz

src/com/google/javascript/jscomp/AliasStrings.java

@@ -16,6 +16,7 @@
 
 package com.google.javascript.jscomp;
 
+import static com.google.common.base.Preconditions.checkState;
 import static java.lang.Math.min;
 
 import com.google.javascript.jscomp.CompilerOptions.AliasStringsMode;
@@ -92,6 +93,7 @@ class AliasStrings implements CompilerPass, NodeTraversal.Callback {
     this.compiler = compiler;
     this.chunkGraph = chunkGraph;
     this.outputStringUsage = outputStringUsage;
+    checkState(aliasStringsMode != AliasStringsMode.NONE);
     this.aliasStringsMode = aliasStringsMode;
   }
 
@@ -226,7 +228,12 @@ private void addAliasDeclarationNodes() {
    * @param str The string literal
    * @param info Accumulated information about a string
    */
-  private static boolean shouldReplaceWithAlias(String str, StringInfo info) {
+  private boolean shouldReplaceWithAlias(String str, StringInfo info) {
+    // Always alias strings if the mode is ALL_AGGRESSIVE.
+    if (aliasStringsMode == AliasStringsMode.ALL_AGGRESSIVE) {
+      return true;
+    }
+
     // Optimize for code size.  Are aliases smaller than strings?
     //
     // This logic optimizes for the size of uncompressed code, but it tends to

src/com/google/javascript/jscomp/CompilerOptions.java

@@ -3183,7 +3183,8 @@ public static enum IsolationMode {
   public static enum AliasStringsMode {
     NONE, // Do not alias string literals.
     LARGE, // Alias all string literals with a length greater than 100 characters.
-    ALL // Alias all string literals.
+    ALL, // Alias all string literals where it may improve code size
+    ALL_AGGRESSIVE // Alias all string regardless of code size
   }
 
   /**

test/com/google/javascript/jscomp/AliasStringsTest.java

@@ -18,6 +18,7 @@
 
 import com.google.javascript.jscomp.CompilerOptions.AliasStringsMode;
 import com.google.javascript.jscomp.testing.JSChunkGraphBuilder;
+import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -46,6 +47,13 @@ protected CompilerPass getProcessor(Compiler compiler) {
     return pass;
   }
 
+  @Override
+  @Before
+  public void setUp() throws Exception {
+    super.setUp();
+    aliasStringsMode = AliasStringsMode.ALL;
+  }
+
   @Test
   public void testTemplateLiteral() {
     // TODO(bradfordcsmith): Maybe implement using aliases in template literals?
@@ -61,6 +69,18 @@ public void testTemplateLiteral() {
             "const AB = `${A}aliasable string${B}`"));
   }
 
+  @Test
+  public void testAliasAggressively() {
+    testSame(lines("function f() { return 'aliasable string'; }"));
+
+    aliasStringsMode = AliasStringsMode.ALL_AGGRESSIVE;
+    test(
+        lines("function f() { return 'aliasable string'; }"),
+        lines(
+            "var $$S_aliasable$20string = 'aliasable string';",
+            "function f() { return $$S_aliasable$20string; }"));
+  }
+
   @Test
   public void testProtectedMessage() {
     test(