Revert "Remove Unicode space handling from <string>.trim()" (#460)

jcking · web-flow · commit ae30eaa53255 · 2025-04-04T12:45:59.000-07:00
Revert "Remove Unicode space handling from <string>.trim() (#453)" This reverts commit 4631ec6.
diff --git a/tests/simple/testdata/string_ext.textproto b/tests/simple/testdata/string_ext.textproto
@@ -244,15 +244,15 @@ section: {
   }
   test: {
     name: "unicode_space_chars_1"
-    expr: "'\\u0085\\u00a0\\u1680text'.trim() == '\\u0085\\u00a0\\u1680text'"
+    expr: "'\\u0085\\u00a0\\u1680text'.trim() == 'text'"
   }
   test: {
     name: "unicode_space_chars_2"
-    expr: "'text\\u2000\\u2001\\u2002\\u2003\\u2004\\u2004\\u2006\\u2007\\u2008\\u2009'.trim() == 'text\\u2000\\u2001\\u2002\\u2003\\u2004\\u2004\\u2006\\u2007\\u2008\\u2009'"
+    expr: "'text\\u2000\\u2001\\u2002\\u2003\\u2004\\u2004\\u2006\\u2007\\u2008\\u2009'.trim() == 'text'"
   }
   test: {
     name: "unicode_space_chars_3"
-    expr: "'\\u200atext\\u2028\\u2029\\u202F\\u205F\\u3000'.trim() == '\\u200atext\\u2028\\u2029\\u202F\\u205F\\u3000'"
+    expr: "'\\u200atext\\u2028\\u2029\\u202F\\u205F\\u3000'.trim() == 'text'"
   }
   test: {
     name: "unicode_no_trim"

Original file line number	Diff line number	Diff line change
`@@ -244,15 +244,15 @@ section: {`
`244`	`244`	`}`
`245`	`245`	`test: {`
`246`	`246`	`name: "unicode_space_chars_1"`
`247`		`- expr: "'\\u0085\\u00a0\\u1680text'.trim() == '\\u0085\\u00a0\\u1680text'"`
	`247`	`+ expr: "'\\u0085\\u00a0\\u1680text'.trim() == 'text'"`
`248`	`248`	`}`
`249`	`249`	`test: {`
`250`	`250`	`name: "unicode_space_chars_2"`
`251`		`- expr: "'text\\u2000\\u2001\\u2002\\u2003\\u2004\\u2004\\u2006\\u2007\\u2008\\u2009'.trim() == 'text\\u2000\\u2001\\u2002\\u2003\\u2004\\u2004\\u2006\\u2007\\u2008\\u2009'"`
	`251`	`+ expr: "'text\\u2000\\u2001\\u2002\\u2003\\u2004\\u2004\\u2006\\u2007\\u2008\\u2009'.trim() == 'text'"`
`252`	`252`	`}`
`253`	`253`	`test: {`
`254`	`254`	`name: "unicode_space_chars_3"`
`255`		`- expr: "'\\u200atext\\u2028\\u2029\\u202F\\u205F\\u3000'.trim() == '\\u200atext\\u2028\\u2029\\u202F\\u205F\\u3000'"`
	`255`	`+ expr: "'\\u200atext\\u2028\\u2029\\u202F\\u205F\\u3000'.trim() == 'text'"`
`256`	`256`	`}`
`257`	`257`	`test: {`
`258`	`258`	`name: "unicode_no_trim"`