Skip to content

Commit b79c170

Browse files
cwgordonronshapiro
authored andcommitted
Do not prepend outer classnames to the generated @autofactory class name if a
class name has been explicitly specified. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=160310315
1 parent 09ae876 commit b79c170

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

factory/src/main/java/com/google/auto/factory/processor/AutoFactoryDeclaration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,12 @@ String getFactoryName() {
6767
if (packageName.length() > 0) {
6868
builder.append('.');
6969
}
70-
for (String enclosingSimpleName : targetEnclosingSimpleNames()) {
71-
builder.append(enclosingSimpleName).append('_');
72-
}
7370
if (className().isPresent()) {
7471
builder.append(className().get());
7572
} else {
73+
for (String enclosingSimpleName : targetEnclosingSimpleNames()) {
74+
builder.append(enclosingSimpleName).append('_');
75+
}
7676
builder.append(targetType().getSimpleName()).append("Factory");
7777
}
7878
return builder.toString();

factory/src/test/java/com/google/auto/factory/processor/AutoFactoryProcessorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void nestedClasses() {
4949
.and()
5050
.generatesSources(
5151
JavaFileObjects.forResource("expected/NestedClasses_SimpleNestedClassFactory.java"),
52-
JavaFileObjects.forResource("expected/NestedClasses_CustomNamedFactory.java"));
52+
JavaFileObjects.forResource("expected/NestedClassCustomNamedFactory.java"));
5353
}
5454

5555
@Test public void simpleClassNonFinal() {

factory/src/test/resources/expected/NestedClasses_CustomNamedFactory.java renamed to factory/src/test/resources/expected/NestedClassCustomNamedFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
value = "com.google.auto.factory.processor.AutoFactoryProcessor",
2323
comments = "https://github.com/google/auto/tree/master/factory"
2424
)
25-
final class NestedClasses_CustomNamedFactory {
26-
@Inject NestedClasses_CustomNamedFactory() {}
25+
final class NestedClassCustomNamedFactory {
26+
@Inject NestedClassCustomNamedFactory() {}
2727

2828
NestedClasses.SimpleNestedClassWithCustomFactory create() {
2929
return new NestedClasses.SimpleNestedClassWithCustomFactory();

factory/src/test/resources/good/NestedClasses.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ final class NestedClasses {
2222
@AutoFactory
2323
static final class SimpleNestedClass {}
2424

25-
@AutoFactory(className = "CustomNamedFactory")
25+
@AutoFactory(className = "NestedClassCustomNamedFactory")
2626
static final class SimpleNestedClassWithCustomFactory {}
27-
}
27+
}

0 commit comments

Comments
 (0)