Skip to content

Commit 5beb73a

Browse files
committed
Remove checkstyle references. It's unclear when the last time this was relevant, but we seem to be ignoring it now anyway.
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=238038517
1 parent de9b78d commit 5beb73a

File tree

3 files changed

+4
-156
lines changed

3 files changed

+4
-156
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,18 @@ If you would like to contribute code to Auto you can do so through GitHub
55
by forking the repository and sending a pull request.
66

77
When submitting code, please make every effort to follow existing conventions
8-
and style in order to keep the code as readable as possible.
8+
and style in order to keep the code as readable as possible.
99

1010
Where appropriate, please provide unit tests or integration tests. Unit tests
1111
should be JUnit based tests and can use either standard JUnit assertions or
12-
Truth assertions and be added to `<project>/src/test/java`. Changes to
13-
code generation or other build-time behaviour should go into small maven
12+
Truth assertions and be added to `<project>/src/test/java`. Changes to
13+
code generation or other build-time behaviour should go into small maven
1414
projects using the `maven-invoker-plugin`. Examples of this are in
1515
`generator/src/it` and can include bean-shell verification scripts and other
1616
facilities provided by `maven-invoker-plugin`.
1717

1818
Please make sure your code compiles by running `mvn clean verify` which will
19-
execute both unit and integration test phases. Additionally, consider using
19+
execute both unit and integration test phases. Additionally, consider using
2020
http://travis-ci.org to validate your branches before you even put them into
2121
pull requests. All pull requests will be validated by Travis-ci in any case
2222
and must pass before being merged.
@@ -27,12 +27,6 @@ note that a Google, Inc. copyright line must appear in every copyright notice.
2727
All files are released with the Apache 2.0 license and any new files may only
2828
be accepted under the terms of that license.
2929

30-
Checkstyle failures during compilation indicate errors in your style and will
31-
be displayed in the console output of the build (including in Travis-CI output),
32-
or can be viewed in the `checkstyle-result.xml` file. To save yourself some
33-
hassle, consider executing checkstyle first per: 'mvn checkstyle:checkstyle'.
34-
It's fast, and will catch style errors early.
35-
3630
Before your code can be accepted into the project you must sign the
3731
[Individual Contributor License Agreement (CLA)][1].
3832

checkstyle.xml

Lines changed: 0 additions & 136 deletions
This file was deleted.

pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -154,16 +154,6 @@
154154
</dependency>
155155
</dependencies>
156156
</plugin>
157-
<plugin>
158-
<groupId>org.apache.maven.plugins</groupId>
159-
<artifactId>maven-checkstyle-plugin</artifactId>
160-
<version>2.17</version>
161-
<configuration>
162-
<consoleOutput>true</consoleOutput>
163-
<configLocation>checkstyle.xml</configLocation>
164-
<failOnViolation>false</failOnViolation>
165-
</configuration>
166-
</plugin>
167157
<plugin>
168158
<groupId>org.apache.maven.plugins</groupId>
169159
<artifactId>maven-jar-plugin</artifactId>

0 commit comments

Comments
 (0)