Update the README.md for AutoValue to reflect the change in primitive array semantics, whereby they are no longer cloned on access.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=100406005

Author: eamonnmcmanus

value/README.md

@@ -551,7 +551,7 @@ If you have multiple creation methods, have them all call through
 to the same point, so there is still one call to the generated file,
 and one place to insert preconditions, etc.
 
-**Avoid mutable field types**, especially if you make your
+**Avoid mutable field types**, such as arrays, especially if you make your
 accessor methods `public`. The generated accessors won't copy the
 field value on its way out, so you'd be exposing your internal
 state. This doesn't mean your factory method can't *accept*
@@ -568,14 +568,6 @@ mutable types as input parameters. Example:
     }
 ```
 
-Primitive arrays are arguably an exception to this, as in this
-case only AutoValue does return a copy of the internal array
-from the generated accessor. It does not automatically copy the
-data on its way in, however, so your static factory method should
-pass `array.clone()` in to the generated constructor instead of
-the input `array` itself. If you are using builders, arrays will
-be cloned in the generated builder.
-
 Finally, if you choose to provide an explicit `equals`, `hashCode`
 or `toString` implementation, please make it **`final`**, so readers
 don't have to wonder whether AutoValue is overriding it.

value/src/it/functional/invoker.properties

@@ -18,28 +18,6 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-/**
- * Specifies that <a href="https://github.com/google/auto/tree/master/value">AutoValue</a> should
- * generate an implementation class for the annotated abstract class, implementing the standard
- * {@link Object} methods like {@link Object#equals equals} to have conventional value semantics. A
- * simple example: <pre>
- *
- *   &#64;AutoValue
- *   abstract class Person {
- *     static Person create(String name, int id) {
- *       return new AutoValue_Person(name, id);
- *     }
- *
- *     abstract String name();
- *     abstract int id();
- *   }</pre>
- *
- * @see <a href="https://github.com/google/auto/tree/master/value">AutoValue User's Guide</a>
- *
- *
- * @author Éamonn McManus
- * @author Kevin Bourrillion
- */
 @Retention(RetentionPolicy.SOURCE)
 @Target(ElementType.TYPE)
 public @interface AutoValue {

value/src/it/functional/pom.xml

@@ -198,7 +198,6 @@ public static class Property {
     private final ExecutableElement method;
     private final String type;
     private final ImmutableList<String> annotations;
-    private final String nullableAnnotation;
 
     Property(
         String name,
@@ -211,18 +210,6 @@ public static class Property {
       this.method = method;
       this.type = type;
       this.annotations = buildAnnotations(typeSimplifier);
-      this.nullableAnnotation = buildNullableAnnotation(typeSimplifier);
-    }
-
-    private String buildNullableAnnotation(TypeSimplifier typeSimplifier) {
-      for (AnnotationMirror annotationMirror : method.getAnnotationMirrors()) {
-        String name = annotationMirror.getAnnotationType().asElement().getSimpleName().toString();
-        if (name.equals("Nullable")) {
-          AnnotationOutput annotationOutput = new AnnotationOutput(typeSimplifier);
-          return annotationOutput.sourceFormForAnnotation(annotationMirror);
-        }
-      }
-      return null;
     }
 
     private ImmutableList<String> buildAnnotations(TypeSimplifier typeSimplifier) {

value/src/main/java/com/google/auto/value/AutoValue.java

@@ -123,6 +123,7 @@ private JavaFileObject expectedCode(List<String> imports, List<String> annotatio
             "@Generated(\"" + AutoValueProcessor.class.getName() + "\")",
             "final class AutoValue_Baz extends Baz {",
             "  private final int buh;",
+            "",
             "  AutoValue_Baz(" + nullable + "int buh) {",
             "    this.buh = buh;",
             "  }",
@@ -165,12 +166,10 @@ private JavaFileObject expectedCode(List<String> imports, List<String> annotatio
     return JavaFileObjects.forSourceLines("foo.bar.AutoValue_Baz", lines);
   }
 
-  
   private void assertGeneratedMatches(
       List<String> imports,
       List<String> annotations,
-      List<String> expectedAnnotations,
-      String expectedConstructorParamAnnotation) {
+      List<String> expectedAnnotations) {
 
     JavaFileObject javaFileObject = sourceCode(imports, annotations);
     JavaFileObject expectedOutput = expectedCode(imports, expectedAnnotations);
@@ -180,14 +179,6 @@ private void assertGeneratedMatches(
         .processedWith(new AutoValueProcessor())
         .compilesWithoutError()
         .and().generatesSources(expectedOutput);
-
-  }
-  
-  private void assertGeneratedMatches(
-      List<String> imports,
-      List<String> annotations,
-      List<String> expectedAnnotations) {
-    assertGeneratedMatches(imports, annotations, expectedAnnotations, null);
   }
 
   public void testSimpleAnnotation() {