Skip to content

Commit b4fd3fd

Browse files
committed
PSDK-162: Fix tags of date dims
Put them all to a dedicated tag(folder). Date dims are not put to the corresponding folder in our Analytical Designer. Also, the same date dim can be created from multiple columns (shared date dims). So the tagging is useless here now, we should think about it in the future.
1 parent 4de4425 commit b4fd3fd

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

gooddata-dbt/gooddata_dbt/dbt/tables.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,11 @@ def make_date_datasets(table: DbtModelTable, existing_date_datasets: List[Dict])
446446
"id": column.ldm_id,
447447
"title": column.gooddata_ldm_title,
448448
"description": column.description,
449-
"tags": [table.gooddata_ldm_title] + column.tags,
449+
# Put them all to a dedicated tag(folder).
450+
# Date dims are not put to the corresponding folder in our Analytical Designer.
451+
# Also, the same date dim can be created from multiple columns (shared date dims).
452+
# So the tagging is useless here now, we should think about it in the future.
453+
"tags": ["Date dimensions"],
450454
"granularities": granularities,
451455
"granularities_formatting": {
452456
"title_base": "",

0 commit comments

Comments
 (0)