fix: proper cred loading for Databricks

chrisbonilla95 · chrisbonilla95 · commit 43e1c7eb3fad · 2025-02-06T10:29:05.000+01:00
client_id field may be empty string, improved check to account for this

JIRA: LX-691
risk: low
diff --git a/gooddata-sdk/gooddata_sdk/catalog/data_source/declarative_model/data_source.py b/gooddata-sdk/gooddata_sdk/catalog/data_source/declarative_model/data_source.py
@@ -35,7 +35,7 @@ def _inject_base(self, credentials: dict[str, Any]) -> DeclarativeDataSources:
                     token = TokenCredentialsFromFile.token_from_file(credentials[data_source.id])
                     data_sources.append(data_source.to_api(token=token))
                 elif data_source.type == DATABRICKS_TYPE:
-                    if data_source.client_id is not None:
+                    if data_source.client_id and data_source.client_id.strip():
                         client_secret = ClientSecretCredentialsFromFile.client_secret_from_file(
                             credentials[data_source.id]
                         )

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ def _inject_base(self, credentials: dict[str, Any]) -> DeclarativeDataSources:`
`35`	`35`	`token = TokenCredentialsFromFile.token_from_file(credentials[data_source.id])`
`36`	`36`	`data_sources.append(data_source.to_api(token=token))`
`37`	`37`	`elif data_source.type == DATABRICKS_TYPE:`
`38`		`- if data_source.client_id is not None:`
	`38`	`+ if data_source.client_id and data_source.client_id.strip():`
`39`	`39`	`client_secret = ClientSecretCredentialsFromFile.client_secret_from_file(`
`40`	`40`	`credentials[data_source.id]`
`41`	`41`	`)`