cmd/go: close elf file in the readpkglist function

testwill · gopherbot · commit ba9c445f166b · 2024-03-30T00:20:35.000Z
Change-Id: Ief08e311598152f047878fc0fe6a6e37df372ee9 GitHub-Last-Rev: daec402 GitHub-Pull-Request: #66588 Reviewed-on: https://go-review.googlesource.com/c/go/+/575156 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
diff --git a/src/cmd/go/internal/work/action.go b/src/cmd/go/internal/work/action.go
@@ -384,6 +384,7 @@ func readpkglist(shlibpath string) (pkgs []*load.Package) {
 		if err != nil {
 			base.Fatal(fmt.Errorf("failed to open shared library: %v", err))
 		}
+		defer f.Close()
 		sect := f.Section(".go_export")
 		if sect == nil {
 			base.Fatal(fmt.Errorf("%s: missing .go_export section", shlibpath))

Original file line number	Diff line number	Diff line change
`@@ -384,6 +384,7 @@ func readpkglist(shlibpath string) (pkgs []*load.Package) {`
`384`	`384`	`if err != nil {`
`385`	`385`	`base.Fatal(fmt.Errorf("failed to open shared library: %v", err))`
`386`	`386`	`}`
	`387`	`+ defer f.Close()`
`387`	`388`	`sect := f.Section(".go_export")`
`388`	`389`	`if sect == nil {`
`389`	`390`	`base.Fatal(fmt.Errorf("%s: missing .go_export section", shlibpath))`